This is an automated email from the ASF dual-hosted git repository.

lidavidm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/master by this push:
     new 7233773  MINOR: [C++] Avoid exposing arrow_vendored::date in public 
headers
7233773 is described below

commit 723377377c58b8cc0c0d62b482938065b9af444f
Author: Antoine Pitrou <[email protected]>
AuthorDate: Wed Oct 6 18:28:48 2021 -0400

    MINOR: [C++] Avoid exposing arrow_vendored::date in public headers
    
    This may also reduce compilation cost slightly.
    
    Closes #11345 from pitrou/vendored-date-inclusion
    
    Authored-by: Antoine Pitrou <[email protected]>
    Signed-off-by: David Li <[email protected]>
---
 cpp/src/arrow/compute/api_scalar.h | 3 +--
 cpp/src/arrow/public_api_test.cc   | 4 ++++
 2 files changed, 5 insertions(+), 2 deletions(-)

diff --git a/cpp/src/arrow/compute/api_scalar.h 
b/cpp/src/arrow/compute/api_scalar.h
index 9acc553..8e1cd48 100644
--- a/cpp/src/arrow/compute/api_scalar.h
+++ b/cpp/src/arrow/compute/api_scalar.h
@@ -23,13 +23,12 @@
 #include <string>
 #include <utility>
 
-#include "arrow/compute/exec.h"  // IWYU pragma: keep
 #include "arrow/compute/function.h"
+#include "arrow/compute/type_fwd.h"
 #include "arrow/datum.h"
 #include "arrow/result.h"
 #include "arrow/util/macros.h"
 #include "arrow/util/visibility.h"
-#include "arrow/vendored/datetime.h"
 
 namespace arrow {
 namespace compute {
diff --git a/cpp/src/arrow/public_api_test.cc b/cpp/src/arrow/public_api_test.cc
index 3446c68..eba14ec 100644
--- a/cpp/src/arrow/public_api_test.cc
+++ b/cpp/src/arrow/public_api_test.cc
@@ -66,6 +66,10 @@
 #error "xsimd should not be visible from Arrow public headers."
 #endif
 
+#ifdef HAS_CHRONO_ROUNDING
+#error "arrow::vendored::date should not be visible from Arrow public headers."
+#endif
+
 #include <gmock/gmock-matchers.h>
 #include <gtest/gtest.h>
 

Reply via email to