This is an automated email from the ASF dual-hosted git repository.
apitrou pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/master by this push:
new 7362fc7 MINOR: [Archery] Update comment
7362fc7 is described below
commit 7362fc7276d16eed172a7534b40cdcbc4fd19aad
Author: Antoine Pitrou <[email protected]>
AuthorDate: Thu Nov 25 14:36:34 2021 +0100
MINOR: [Archery] Update comment
Followup to ARROW-14851; I forgot to do it before merging.
Closes #11775 from pitrou/minor-archery-comment
Authored-by: Antoine Pitrou <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
---
dev/archery/archery/cli.py | 6 +++---
1 file changed, 3 insertions(+), 3 deletions(-)
diff --git a/dev/archery/archery/cli.py b/dev/archery/archery/cli.py
index 9d6c1db..4fc2022 100644
--- a/dev/archery/archery/cli.py
+++ b/dev/archery/archery/cli.py
@@ -494,9 +494,9 @@ def benchmark_run(ctx, rev_or_path, src, preserve, output,
cmake_extras,
repetitions=repetitions,
benchmark_filter=benchmark_filter)
- # XXX for some weird reason, running the benchmarks is coupled
- # with JSON-encoding their results, so need to run `json` on
- # the benchmark runner even when no JSON output is requested.
+ # XXX for some reason, the benchmark runner only does its work
+ # when asked to JSON-serialize the results, so produce a JSON
+ # output even when none is requested.
json_out = json.dumps(runner_base, cls=JsonEncoder)
if output is not None:
output.write(json_out)
