This is an automated email from the ASF dual-hosted git repository.
alamb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow-rs.git
The following commit(s) were added to refs/heads/master by this push:
new d37f580 fix bug: error type for BufferBuilder (#1104)
d37f580 is described below
commit d37f580e9d4f80362ab85deeae929985d9d7a426
Author: Kun Liu <[email protected]>
AuthorDate: Sun Jan 2 19:06:40 2022 +0800
fix bug: error type for BufferBuilder (#1104)
* fix bug: error type for BufferBuilder
* fix clippy
---
arrow/src/array/mod.rs | 83 +++++++++++++++++++++++++++++++++++++++-----------
1 file changed, 66 insertions(+), 17 deletions(-)
diff --git a/arrow/src/array/mod.rs b/arrow/src/array/mod.rs
index 1145e83..dbeaab7 100644
--- a/arrow/src/array/mod.rs
+++ b/arrow/src/array/mod.rs
@@ -414,23 +414,38 @@ pub type UInt64BufferBuilder = BufferBuilder<u64>;
pub type Float32BufferBuilder = BufferBuilder<f32>;
pub type Float64BufferBuilder = BufferBuilder<f64>;
-pub type TimestampSecondBufferBuilder = BufferBuilder<TimestampSecondType>;
-pub type TimestampMillisecondBufferBuilder =
BufferBuilder<TimestampMillisecondType>;
-pub type TimestampMicrosecondBufferBuilder =
BufferBuilder<TimestampMicrosecondType>;
-pub type TimestampNanosecondBufferBuilder =
BufferBuilder<TimestampNanosecondType>;
-pub type Date32BufferBuilder = BufferBuilder<Date32Type>;
-pub type Date64BufferBuilder = BufferBuilder<Date64Type>;
-pub type Time32SecondBufferBuilder = BufferBuilder<Time32SecondType>;
-pub type Time32MillisecondBufferBuilder = BufferBuilder<Time32MillisecondType>;
-pub type Time64MicrosecondBufferBuilder = BufferBuilder<Time64MicrosecondType>;
-pub type Time64NanosecondBufferBuilder = BufferBuilder<Time64NanosecondType>;
-pub type IntervalYearMonthBufferBuilder = BufferBuilder<IntervalYearMonthType>;
-pub type IntervalDayTimeBufferBuilder = BufferBuilder<IntervalDayTimeType>;
-pub type IntervalMonthDayNanoBufferBuilder =
BufferBuilder<IntervalMonthDayNanoType>;
-pub type DurationSecondBufferBuilder = BufferBuilder<DurationSecondType>;
-pub type DurationMillisecondBufferBuilder =
BufferBuilder<DurationMillisecondType>;
-pub type DurationMicrosecondBufferBuilder =
BufferBuilder<DurationMicrosecondType>;
-pub type DurationNanosecondBufferBuilder =
BufferBuilder<DurationNanosecondType>;
+pub type TimestampSecondBufferBuilder =
+ BufferBuilder<<TimestampSecondType as ArrowPrimitiveType>::Native>;
+pub type TimestampMillisecondBufferBuilder =
+ BufferBuilder<<TimestampMillisecondType as ArrowPrimitiveType>::Native>;
+pub type TimestampMicrosecondBufferBuilder =
+ BufferBuilder<<TimestampMicrosecondType as ArrowPrimitiveType>::Native>;
+pub type TimestampNanosecondBufferBuilder =
+ BufferBuilder<<TimestampNanosecondType as ArrowPrimitiveType>::Native>;
+pub type Date32BufferBuilder = BufferBuilder<<Date32Type as
ArrowPrimitiveType>::Native>;
+pub type Date64BufferBuilder = BufferBuilder<<Date64Type as
ArrowPrimitiveType>::Native>;
+pub type Time32SecondBufferBuilder =
+ BufferBuilder<<Time32SecondType as ArrowPrimitiveType>::Native>;
+pub type Time32MillisecondBufferBuilder =
+ BufferBuilder<<Time32MillisecondType as ArrowPrimitiveType>::Native>;
+pub type Time64MicrosecondBufferBuilder =
+ BufferBuilder<<Time64MicrosecondType as ArrowPrimitiveType>::Native>;
+pub type Time64NanosecondBufferBuilder =
+ BufferBuilder<<Time64NanosecondType as ArrowPrimitiveType>::Native>;
+pub type IntervalYearMonthBufferBuilder =
+ BufferBuilder<<IntervalYearMonthType as ArrowPrimitiveType>::Native>;
+pub type IntervalDayTimeBufferBuilder =
+ BufferBuilder<<IntervalDayTimeType as ArrowPrimitiveType>::Native>;
+pub type IntervalMonthDayNanoBufferBuilder =
+ BufferBuilder<<IntervalMonthDayNanoType as ArrowPrimitiveType>::Native>;
+pub type DurationSecondBufferBuilder =
+ BufferBuilder<<DurationSecondType as ArrowPrimitiveType>::Native>;
+pub type DurationMillisecondBufferBuilder =
+ BufferBuilder<<DurationMillisecondType as ArrowPrimitiveType>::Native>;
+pub type DurationMicrosecondBufferBuilder =
+ BufferBuilder<<DurationMicrosecondType as ArrowPrimitiveType>::Native>;
+pub type DurationNanosecondBufferBuilder =
+ BufferBuilder<<DurationNanosecondType as ArrowPrimitiveType>::Native>;
pub use self::builder::ArrayBuilder;
pub use self::builder::BinaryBuilder;
@@ -506,3 +521,37 @@ pub use self::cast::{
// ------------------------------ C Data Interface ---------------------------
pub use self::array::make_array_from_raw;
+
+#[cfg(test)]
+mod tests {
+ use crate::array::*;
+
+ #[test]
+ fn test_buffer_builder_availability() {
+ let _builder = Int8BufferBuilder::new(10);
+ let _builder = Int16BufferBuilder::new(10);
+ let _builder = Int32BufferBuilder::new(10);
+ let _builder = Int64BufferBuilder::new(10);
+ let _builder = UInt16BufferBuilder::new(10);
+ let _builder = UInt32BufferBuilder::new(10);
+ let _builder = Float32BufferBuilder::new(10);
+ let _builder = Float64BufferBuilder::new(10);
+ let _builder = TimestampSecondBufferBuilder::new(10);
+ let _builder = TimestampMillisecondBufferBuilder::new(10);
+ let _builder = TimestampMicrosecondBufferBuilder::new(10);
+ let _builder = TimestampNanosecondBufferBuilder::new(10);
+ let _builder = Date32BufferBuilder::new(10);
+ let _builder = Date64BufferBuilder::new(10);
+ let _builder = Time32SecondBufferBuilder::new(10);
+ let _builder = Time32MillisecondBufferBuilder::new(10);
+ let _builder = Time64MicrosecondBufferBuilder::new(10);
+ let _builder = Time64NanosecondBufferBuilder::new(10);
+ let _builder = IntervalYearMonthBufferBuilder::new(10);
+ let _builder = IntervalDayTimeBufferBuilder::new(10);
+ let _builder = IntervalMonthDayNanoBufferBuilder::new(10);
+ let _builder = DurationSecondBufferBuilder::new(10);
+ let _builder = DurationMillisecondBufferBuilder::new(10);
+ let _builder = DurationMicrosecondBufferBuilder::new(10);
+ let _builder = DurationNanosecondBufferBuilder::new(10);
+ }
+}
