This is an automated email from the ASF dual-hosted git repository.
jonkeane pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/master by this push:
new 63d2a9c856 ARROW-16201: [R] SafeCallIntoR on 3.4
63d2a9c856 is described below
commit 63d2a9c856969a2c05e12ae8857a135bceaf45c1
Author: Jonathan Keane <jke...@gmail.com>
AuthorDate: Thu Apr 14 15:28:44 2022 -0500
ARROW-16201: [R] SafeCallIntoR on 3.4
Disabling the tests for now, 3.4 will no longer be in our support window
shortly with the release of 4.2 also skip a number of tests that failed because
of `tzone` being non-present on 3.4.
Closes #12887 from jonkeane/ARROW-16201
Authored-by: Jonathan Keane <jke...@gmail.com>
Signed-off-by: Jonathan Keane <jke...@gmail.com>
---
r/tests/testthat/test-dplyr-funcs-datetime.R | 2 ++
r/tests/testthat/test-dplyr-funcs-type.R | 2 ++
r/tests/testthat/test-safe-call-into-r.R | 1 +
3 files changed, 5 insertions(+)
diff --git a/r/tests/testthat/test-dplyr-funcs-datetime.R
b/r/tests/testthat/test-dplyr-funcs-datetime.R
index 79b922f6e2..fc030779ec 100644
--- a/r/tests/testthat/test-dplyr-funcs-datetime.R
+++ b/r/tests/testthat/test-dplyr-funcs-datetime.R
@@ -16,6 +16,8 @@
# under the License.
skip_if(on_old_windows())
+# In 3.4 the lack of tzone attribute causes spurious failures
+skip_if_r_version("3.4.4")
library(lubridate, warn.conflicts = FALSE)
library(dplyr, warn.conflicts = FALSE)
diff --git a/r/tests/testthat/test-dplyr-funcs-type.R
b/r/tests/testthat/test-dplyr-funcs-type.R
index 6c9d9ac07a..aa6667420c 100644
--- a/r/tests/testthat/test-dplyr-funcs-type.R
+++ b/r/tests/testthat/test-dplyr-funcs-type.R
@@ -877,6 +877,8 @@ test_that("as.Date() converts successfully from date,
timestamp, integer, char a
test_that("format date/time", {
skip_on_os("windows") # https://issues.apache.org/jira/browse/ARROW-13168
+ # In 3.4 the lack of tzone attribute causes spurious failures
+ skip_if_r_version("3.4.4")
times <- tibble(
datetime = c(lubridate::ymd_hms("2018-10-07 19:04:05", tz =
"Pacific/Marquesas"), NA),
diff --git a/r/tests/testthat/test-safe-call-into-r.R
b/r/tests/testthat/test-safe-call-into-r.R
index e9438de58b..55cb68abdd 100644
--- a/r/tests/testthat/test-safe-call-into-r.R
+++ b/r/tests/testthat/test-safe-call-into-r.R
@@ -46,6 +46,7 @@ test_that("SafeCallIntoR works within RunWithCapturedR", {
})
test_that("SafeCallIntoR errors from the non-R thread", {
+ skip_if_r_version("3.4.4")
skip_on_cran()
expect_error(
