This is an automated email from the ASF dual-hosted git repository.
jorisvandenbossche pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/master by this push:
new ee31931e8b MINOR: Add feedback information output when building in
case of skipping pyarrow build
ee31931e8b is described below
commit ee31931e8b5e1e709e2aeb2f2ed984376920ba82
Author: Raúl Cumplido <[email protected]>
AuthorDate: Thu May 12 11:28:30 2022 +0200
MINOR: Add feedback information output when building in case of skipping
pyarrow build
This minor PR tries to give the user a better hint on what is happening in
case of their build being skipped because `cachedir != build_temp`. I faced the
issue and had to ask and debug to understand that I had to clean my previous
build:
```
(pyarrow-dev) ~/arrow/python (master) $ python setup.py build_ext --inplace
running build_ext
(pyarrow-dev) ~/arrow/python (master) $
```
The new output will show on that case:
```
(pyarrow-dev) ~/arrow/python (master) $ python setup.py build_ext --inplace
running build_ext
-- Skipping build. Temp build
/home/raulcd/arrow/python/build/temp.linux-x86_64-3.10 does not match cached
dir /arrow/python/build/temp.linux-x86_64-3.10
(pyarrow-dev) ~/arrow/python (master) $
```
Closes #13119 from raulcd/minor-feedback-improvement
Authored-by: Raúl Cumplido <[email protected]>
Signed-off-by: Joris Van den Bossche <[email protected]>
---
python/setup.py | 5 +++++
1 file changed, 5 insertions(+)
diff --git a/python/setup.py b/python/setup.py
index a5221d7feb..1189357b23 100755
--- a/python/setup.py
+++ b/python/setup.py
@@ -245,6 +245,11 @@ class build_ext(_build_ext):
cachefile.read()).group(1)
cachefile.close()
if (cachedir != build_temp):
+ build_base = pjoin(saved_cwd, build_cmd.build_base)
+ print(f"-- Skipping build. Temp build {build_temp} does "
+ f"not match cached dir {cachedir}")
+ print("---- For a clean build you might want to delete "
+ f"{build_base}.")
return
static_lib_option = ''
