This is an automated email from the ASF dual-hosted git repository.

kou pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/master by this push:
     new d5a945378c ARROW-16869: [CI][C++][Homebrew] Build Apache Arrow with 
C++17 (#13407)
d5a945378c is described below

commit d5a945378cdd6147ccea527e592a5cf98bcf397b
Author: Neal Richardson <[email protected]>
AuthorDate: Wed Jun 22 02:15:37 2022 -0400

    ARROW-16869: [CI][C++][Homebrew] Build Apache Arrow with C++17 (#13407)
    
    The `homebrew-r-brew` nightly job has been failing since the ARROW_GCS flag 
was turned on in 
[ARROW-14892](https://issues.apache.org/jira/browse/ARROW-14892). The failure 
is an undefined absl symbol
    
    ```
    ** testing if installed package can be loaded from temporary location
    Error: Error: package or namespace load failed for ‘arrow’ in 
dyn.load(file, DLLpath = DLLpath, ...):
     unable to load shared object 
'/Users/runner/work/crossbow/crossbow/arrow/r/check/arrow.Rcheck/00LOCK-arrow/00new/arrow/libs/arrow.so':
      
dlopen(/Users/runner/work/crossbow/crossbow/arrow/r/check/arrow.Rcheck/00LOCK-arrow/00new/arrow/libs/arrow.so,
 6): Symbol not found: 
__ZN4absl12lts_2021110210FormatTimeENS0_11string_viewENS0_4TimeENS0_8TimeZoneE
      Referenced from: /usr/local/opt/apache-arrow/lib/libarrow.900.dylib
      Expected in: flat namespace
     in /usr/local/opt/apache-arrow/lib/libarrow.900.dylib
    ```
    
    We need to build Apache Arrow with C++17 because system Abseil installed by 
Homebrew uses C++17 and we use
    Abseil features such as `absl::FormatTime()` in `gcsfs_internal.cc`.
    
    
    Authored-by: Neal Richardson <[email protected]>
    Signed-off-by: Sutou Kouhei <[email protected]>
---
 dev/tasks/homebrew-formulae/apache-arrow.rb | 1 +
 1 file changed, 1 insertion(+)

diff --git a/dev/tasks/homebrew-formulae/apache-arrow.rb 
b/dev/tasks/homebrew-formulae/apache-arrow.rb
index 94a1a67a1a..4908c22ed6 100644
--- a/dev/tasks/homebrew-formulae/apache-arrow.rb
+++ b/dev/tasks/homebrew-formulae/apache-arrow.rb
@@ -89,6 +89,7 @@ class ApacheArrow < Formula
       -DARROW_WITH_UTF8PROC=ON
       -DARROW_WITH_ZLIB=ON
       -DARROW_WITH_ZSTD=ON
+      -DCMAKE_CXX_STANDARD=17
       -DCMAKE_FIND_PACKAGE_PREFER_CONFIG=TRUE
       -DPython3_EXECUTABLE=#{Formula["[email protected]"].bin/"python3"}
     ]

Reply via email to