This is an automated email from the ASF dual-hosted git repository.
alamb pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow-datafusion.git
The following commit(s) were added to refs/heads/master by this push:
new b6370ee92 Update CONTRIBUTING.md (#2876)
b6370ee92 is described below
commit b6370ee92de0cedd7884f3a4cc69fae10947599d
Author: Wei-Ting Kuo <[email protected]>
AuthorDate: Tue Jul 12 05:18:51 2022 +0800
Update CONTRIBUTING.md (#2876)
expression code moved to datafusion-expr #2669
---
CONTRIBUTING.md | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/CONTRIBUTING.md b/CONTRIBUTING.md
index 7dfc7a23f..48b244712 100644
--- a/CONTRIBUTING.md
+++ b/CONTRIBUTING.md
@@ -186,7 +186,7 @@ Below is a checklist of what you need to do to add a new
scalar function to Data
- a new line in `create_physical_expr`/`create_physical_fun` mapping the
built-in to the implementation
- tests to the function.
- In [core/tests/sql](datafusion/core/tests/sql), add a new test where the
function is called through SQL against well known data and returns the expected
result.
-- In [core/src/logical_plan/expr](datafusion/core/src/logical_plan/expr.rs),
add:
+- In [expr/src/expr_fn.rs](datafusion/expr/src/expr_fn.rs), add:
- a new entry of the `unary_scalar_expr!` macro for the new function.
- In [core/src/logical_plan/mod](datafusion/core/src/logical_plan/mod.rs), add:
- a new entry in the `pub use expr::{}` set.
