This is an automated email from the ASF dual-hosted git repository.
lidavidm pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/master by this push:
new 1fd3593962 ARROW-17055: [Java][FlightRPC] Don't duplicate generated
Protobuf classes between flight-core and flight-sql (#13596)
1fd3593962 is described below
commit 1fd3593962d8a57b3e2e780fee7db1ae3c7c0a80
Author: KBambrick1 <[email protected]>
AuthorDate: Wed Jul 13 15:52:46 2022 +0100
ARROW-17055: [Java][FlightRPC] Don't duplicate generated Protobuf classes
between flight-core and flight-sql (#13596)
flight-core and flight-sql jars delivering same class names.
It seems that the classes generated by Flight.proto gets generated in both
flight-sql and flight-core jars. Since these classes get generated in
flight-core, and flight-sql is dependent on flight-core, can the generation of
Flight.java and FlightServiceGrpc.java be removed from flight-sql and instead
rely on it to be pulled directly from flight-core.
Authored-by: KBambrick1 <[email protected]>
Signed-off-by: David Li <[email protected]>
---
java/flight/flight-sql/pom.xml | 35 -----------------------------------
1 file changed, 35 deletions(-)
diff --git a/java/flight/flight-sql/pom.xml b/java/flight/flight-sql/pom.xml
index 63785d7584..8af1fa7086 100644
--- a/java/flight/flight-sql/pom.xml
+++ b/java/flight/flight-sql/pom.xml
@@ -57,26 +57,14 @@
<artifactId>arrow-jdbc</artifactId>
<version>${project.version}</version>
</dependency>
- <dependency>
- <groupId>io.grpc</groupId>
- <artifactId>grpc-protobuf</artifactId>
- </dependency>
<dependency>
<groupId>com.google.guava</groupId>
<artifactId>guava</artifactId>
</dependency>
- <dependency>
- <groupId>io.grpc</groupId>
- <artifactId>grpc-stub</artifactId>
- </dependency>
<dependency>
<groupId>com.google.protobuf</groupId>
<artifactId>protobuf-java</artifactId>
</dependency>
- <dependency>
- <groupId>io.grpc</groupId>
- <artifactId>grpc-api</artifactId>
- </dependency>
<dependency>
<groupId>org.apache.arrow</groupId>
<artifactId>arrow-vector</artifactId>
@@ -122,27 +110,4 @@
</dependency>
</dependencies>
- <build>
- <plugins>
- <plugin>
- <groupId>org.xolstice.maven.plugins</groupId>
- <artifactId>protobuf-maven-plugin</artifactId>
- <version>0.6.1</version>
- <executions>
- <execution>
- <id>proto-compile</id>
- <phase>generate-sources</phase>
- <configuration>
- <protoSourceRoot>${basedir}/../../../format/</protoSourceRoot>
- </configuration>
- <goals>
- <goal>compile</goal>
- <goal>compile-custom</goal>
- </goals>
- </execution>
- </executions>
- </plugin>
- </plugins>
- </build>
-
</project>
