This is an automated email from the ASF dual-hosted git repository.
thisisnic pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/master by this push:
new 8ec29ce480 ARROW-17717: [R] Lintr error on CI (#14113)
8ec29ce480 is described below
commit 8ec29ce4803807a30ff07b0077d0def6b8861680
Author: Nic Crane <[email protected]>
AuthorDate: Wed Sep 14 09:28:23 2022 +0100
ARROW-17717: [R] Lintr error on CI (#14113)
The new release of lintr has a new feature - giving a warning when code is
commented out - which is causing the lintr-containing CI job to fail. We could
have pinned to a previous version of lintr, but that seem like a useful feature
& the lines of code which trigger it seem like reasonable exceptions, so I've
just added a #nolint flag on each of them.
Authored-by: Nic Crane <[email protected]>
Signed-off-by: Nic Crane <[email protected]>
---
r/tests/testthat/test-dplyr-funcs-type.R | 8 ++++----
1 file changed, 4 insertions(+), 4 deletions(-)
diff --git a/r/tests/testthat/test-dplyr-funcs-type.R
b/r/tests/testthat/test-dplyr-funcs-type.R
index 5770e6ff43..285d86520f 100644
--- a/r/tests/testthat/test-dplyr-funcs-type.R
+++ b/r/tests/testthat/test-dplyr-funcs-type.R
@@ -420,12 +420,12 @@ test_that("type checks with is() giving R types", {
i64_is_chr = is(i64, "character"),
i64_is_fct = is(i64, "factor"),
# we want Arrow to return TRUE, but bit64 returns FALSE
- # i64_is_int = is(i64, "integer"),
+ # i64_is_int = is(i64, "integer"), # nolint
i64_is_i64 = is(i64, "integer64"),
i64_is_lst = is(i64, "list"),
i64_is_lgl = is(i64, "logical"),
# we want Arrow to return TRUE, but bit64 returns FALSE
- # i64_is_num = is(i64, "numeric"),
+ # i64_is_num = is(i64, "numeric"), # nolint
lst_is_chr = is(lst, "character"),
lst_is_fct = is(lst, "factor"),
lst_is_int = is(lst, "integer"),
@@ -504,10 +504,10 @@ test_that("type checks with is.*()", {
transmute(
i64_is_chr = is.character(i64),
# TODO: investigate why this is not matching when testthat runs it
- # i64_is_dbl = is.double(i64),
+ # i64_is_dbl = is.double(i64), # nolint
i64_is_fct = is.factor(i64),
# we want Arrow to return TRUE, but bit64 returns FALSE
- # i64_is_int = is.integer(i64),
+ # i64_is_int = is.integer(i64), # nolint
i64_is_i64 = is.integer64(i64),
i64_is_lst = is.list(i64),
i64_is_lgl = is.logical(i64),
