This is an automated email from the ASF dual-hosted git repository.
tustvold pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow-datafusion.git
The following commit(s) were added to refs/heads/master by this push:
new 8bcc96532 Merge s3_build_error and s3_success into one test (#3602)
8bcc96532 is described below
commit 8bcc96532ad4272bebff09796b6dda87b9030a9a
Author: Rito Takeuchi <[email protected]>
AuthorDate: Sat Sep 24 21:36:56 2022 +0900
Merge s3_build_error and s3_success into one test (#3602)
---
datafusion-cli/src/object_storage.rs | 7 +------
1 file changed, 1 insertion(+), 6 deletions(-)
diff --git a/datafusion-cli/src/object_storage.rs
b/datafusion-cli/src/object_storage.rs
index 861830d81..4d21e84a1 100644
--- a/datafusion-cli/src/object_storage.rs
+++ b/datafusion-cli/src/object_storage.rs
@@ -130,20 +130,15 @@ mod tests {
}
#[test]
- fn s3_build_error() {
+ fn s3_region_validation() {
let s3 = "s3://bucket_name/path";
let provider = DatafusionCliObjectStoreProvider {};
let err = provider
.get_by_url(&Url::from_str(s3).unwrap())
.unwrap_err();
assert!(err.to_string().contains("Generic S3 error: Missing region"));
- }
- #[test]
- fn s3_success() {
- let s3 = "s3://bucket_name/path";
env::set_var("AWS_DEFAULT_REGION", "us-east-1");
- let provider = DatafusionCliObjectStoreProvider {};
assert!(provider.get_by_url(&Url::from_str(s3).unwrap()).is_ok());
env::remove_var("AWS_DEFAULT_REGION");
}