This is an automated email from the ASF dual-hosted git repository.
nju_yaho pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow-ballista.git
The following commit(s) were added to refs/heads/master by this push:
new af03e8c3 Fix clippy warning (#495)
af03e8c3 is described below
commit af03e8c3bc4a92bd9874ec7ef85c77f6b08d30de
Author: yahoNanJing <[email protected]>
AuthorDate: Fri Nov 4 10:00:55 2022 +0800
Fix clippy warning (#495)
* Fix clippy warning
* Fix clippy
* Fix clippy
* Fix clippy
Co-authored-by: yangzhong <[email protected]>
---
ballista-cli/src/main.rs | 2 +-
ballista/client/src/context.rs | 36 +++++++++++-----------
.../core/src/execution_plans/shuffle_reader.rs | 2 +-
ballista/core/src/serde/physical_plan/mod.rs | 1 +
ballista/core/src/utils.rs | 2 +-
ballista/executor/src/flight_service.rs | 4 +--
ballista/scheduler/src/state/backend/etcd.rs | 4 +--
7 files changed, 26 insertions(+), 25 deletions(-)
diff --git a/ballista-cli/src/main.rs b/ballista-cli/src/main.rs
index 458cdc68..5cfd019f 100644
--- a/ballista-cli/src/main.rs
+++ b/ballista-cli/src/main.rs
@@ -101,7 +101,7 @@ pub async fn main() -> Result<()> {
if let Some(ref path) = args.data_path {
let p = Path::new(path);
- env::set_current_dir(&p).unwrap();
+ env::set_current_dir(p).unwrap();
};
let mut ballista_config_builder =
diff --git a/ballista/client/src/context.rs b/ballista/client/src/context.rs
index 22c849c6..9c1b9e67 100644
--- a/ballista/client/src/context.rs
+++ b/ballista/client/src/context.rs
@@ -659,7 +659,7 @@ mod tests {
];
assert_eq!(
expected1,
- pretty_format_batches(&*res1)
+ pretty_format_batches(&res1)
.unwrap()
.to_string()
.trim()
@@ -681,7 +681,7 @@ mod tests {
let res2 = df.collect().await.unwrap();
assert_eq!(
expected2,
- pretty_format_batches(&*res2)
+ pretty_format_batches(&res2)
.unwrap()
.to_string()
.trim()
@@ -725,7 +725,7 @@ mod tests {
"| 0 |",
"+--------------+",
];
- assert_result_eq(expected, &*res);
+ assert_result_eq(expected, &res);
let df = context.sql("select max(\"id\") from test").await.unwrap();
let res = df.collect().await.unwrap();
@@ -736,7 +736,7 @@ mod tests {
"| 7 |",
"+--------------+",
];
- assert_result_eq(expected, &*res);
+ assert_result_eq(expected, &res);
let df = context.sql("select SUM(\"id\") from test").await.unwrap();
let res = df.collect().await.unwrap();
@@ -747,7 +747,7 @@ mod tests {
"| 28 |",
"+--------------+",
];
- assert_result_eq(expected, &*res);
+ assert_result_eq(expected, &res);
let df = context.sql("select AVG(\"id\") from test").await.unwrap();
let res = df.collect().await.unwrap();
@@ -758,7 +758,7 @@ mod tests {
"| 3.5 |",
"+--------------+",
];
- assert_result_eq(expected, &*res);
+ assert_result_eq(expected, &res);
let df = context.sql("select COUNT(\"id\") from test").await.unwrap();
let res = df.collect().await.unwrap();
@@ -769,7 +769,7 @@ mod tests {
"| 8 |",
"+----------------+",
];
- assert_result_eq(expected, &*res);
+ assert_result_eq(expected, &res);
let df = context
.sql("select approx_distinct(\"id\") from test")
@@ -783,7 +783,7 @@ mod tests {
"| 8 |",
"+-------------------------+",
];
- assert_result_eq(expected, &*res);
+ assert_result_eq(expected, &res);
let df = context
.sql("select ARRAY_AGG(\"id\") from test")
@@ -797,7 +797,7 @@ mod tests {
"| [4, 5, 6, 7, 2, 3, 0, 1] |",
"+--------------------------+",
];
- assert_result_eq(expected, &*res);
+ assert_result_eq(expected, &res);
let df = context.sql("select VAR(\"id\") from test").await.unwrap();
let res = df.collect().await.unwrap();
@@ -808,7 +808,7 @@ mod tests {
"| 6.000000000000001 |",
"+-------------------+",
];
- assert_result_eq(expected, &*res);
+ assert_result_eq(expected, &res);
let df = context
.sql("select VAR_POP(\"id\") from test")
@@ -822,7 +822,7 @@ mod tests {
"| 5.250000000000001 |",
"+----------------------+",
];
- assert_result_eq(expected, &*res);
+ assert_result_eq(expected, &res);
let df = context
.sql("select VAR_SAMP(\"id\") from test")
@@ -836,7 +836,7 @@ mod tests {
"| 6.000000000000001 |",
"+-------------------+",
];
- assert_result_eq(expected, &*res);
+ assert_result_eq(expected, &res);
let df = context
.sql("select STDDEV(\"id\") from test")
@@ -850,7 +850,7 @@ mod tests {
"| 2.4494897427831783 |",
"+--------------------+",
];
- assert_result_eq(expected, &*res);
+ assert_result_eq(expected, &res);
let df = context
.sql("select STDDEV_SAMP(\"id\") from test")
@@ -864,7 +864,7 @@ mod tests {
"| 2.4494897427831783 |",
"+--------------------+",
];
- assert_result_eq(expected, &*res);
+ assert_result_eq(expected, &res);
let df = context
.sql("select COVAR(id, tinyint_col) from test")
@@ -878,7 +878,7 @@ mod tests {
"| 0.28571428571428586 |",
"+--------------------------------------+",
];
- assert_result_eq(expected, &*res);
+ assert_result_eq(expected, &res);
let df = context
.sql("select CORR(id, tinyint_col) from test")
@@ -892,7 +892,7 @@ mod tests {
"| 0.21821789023599245 |",
"+---------------------------------------+",
];
- assert_result_eq(expected, &*res);
+ assert_result_eq(expected, &res);
let df = context
.sql("select approx_percentile_cont_with_weight(\"id\", 2, 0.5)
from test")
@@ -906,7 +906,7 @@ mod tests {
"| 1
|",
"+---------------------------------------------------------------+",
];
- assert_result_eq(expected, &*res);
+ assert_result_eq(expected, &res);
let df = context
.sql("select approx_percentile_cont(\"double_col\", 0.5) from
test")
@@ -921,7 +921,7 @@ mod tests {
"+----------------------------------------------------+",
];
- assert_result_eq(expected, &*res);
+ assert_result_eq(expected, &res);
fn assert_result_eq(
expected: Vec<&str>,
diff --git a/ballista/core/src/execution_plans/shuffle_reader.rs
b/ballista/core/src/execution_plans/shuffle_reader.rs
index 298b3021..5411978f 100644
--- a/ballista/core/src/execution_plans/shuffle_reader.rs
+++ b/ballista/core/src/execution_plans/shuffle_reader.rs
@@ -406,7 +406,7 @@ async fn fetch_partition_local(
fn fetch_partition_local_inner(
path: &str,
) -> result::Result<FileReader<File>, BallistaError> {
- let file = File::open(&path).map_err(|e| {
+ let file = File::open(path).map_err(|e| {
BallistaError::General(format!(
"Failed to open partition file at {}: {:?}",
path, e
diff --git a/ballista/core/src/serde/physical_plan/mod.rs
b/ballista/core/src/serde/physical_plan/mod.rs
index b35108df..5860f570 100644
--- a/ballista/core/src/serde/physical_plan/mod.rs
+++ b/ballista/core/src/serde/physical_plan/mod.rs
@@ -98,6 +98,7 @@ impl AsExecutionPlan for PhysicalPlanNode {
})
}
+ #[allow(clippy::only_used_in_recursion)]
fn try_into_physical_plan(
&self,
registry: &dyn FunctionRegistry,
diff --git a/ballista/core/src/utils.rs b/ballista/core/src/utils.rs
index 436a0c45..8eb77226 100644
--- a/ballista/core/src/utils.rs
+++ b/ballista/core/src/utils.rs
@@ -122,7 +122,7 @@ pub async fn write_stream_to_disk(
path: &str,
disk_write_metric: &metrics::Time,
) -> Result<PartitionStats> {
- let file = File::create(&path).map_err(|e| {
+ let file = File::create(path).map_err(|e| {
error!("Failed to create partition file at {}: {:?}", path, e);
BallistaError::IoError(e)
})?;
diff --git a/ballista/executor/src/flight_service.rs
b/ballista/executor/src/flight_service.rs
index fde4f045..d12686ed 100644
--- a/ballista/executor/src/flight_service.rs
+++ b/ballista/executor/src/flight_service.rs
@@ -90,8 +90,8 @@ impl FlightService for BallistaFlightService {
match &action {
BallistaAction::FetchPartition { path, .. } => {
- debug!("FetchPartition reading {}", &path);
- let file = File::open(&path)
+ debug!("FetchPartition reading {}", path);
+ let file = File::open(path)
.map_err(|e| {
BallistaError::General(format!(
"Failed to open partition file at {}: {:?}",
diff --git a/ballista/scheduler/src/state/backend/etcd.rs
b/ballista/scheduler/src/state/backend/etcd.rs
index e753df66..f0d48b3f 100644
--- a/ballista/scheduler/src/state/backend/etcd.rs
+++ b/ballista/scheduler/src/state/backend/etcd.rs
@@ -139,7 +139,7 @@ impl StateBackendClient for EtcdClient {
.await
.map_err(|e| {
warn!("etcd put failed: {}", e);
- ballista_error(&*format!("etcd put failed: {}", e))
+ ballista_error(&format!("etcd put failed: {}", e))
})
.map(|_| ())
}
@@ -163,7 +163,7 @@ impl StateBackendClient for EtcdClient {
.await
.map_err(|e| {
error!("etcd operation failed: {}", e);
- ballista_error(&*format!("etcd operation failed: {}", e))
+ ballista_error(&format!("etcd operation failed: {}", e))
})
.map(|_| ())
}
