This is an automated email from the ASF dual-hosted git repository.
thisisnic pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/master by this push:
new 32c713066d GH-33709: [R] Remove suffix argument from semi_join and
anti_join (#34030)
32c713066d is described below
commit 32c713066d4ff04bde1f1ee867292ada4ca564ce
Author: Nic Crane <[email protected]>
AuthorDate: Mon Feb 6 07:55:55 2023 +0000
GH-33709: [R] Remove suffix argument from semi_join and anti_join (#34030)
The function signatures for `semi_join()` and `anti_join()` don't match
those of dplyr. This PR removes the argument `suffix` from `anti_join()` and
`semi_join()`. Is this change necessary/useful or just pedantic? Unsure.
* Closes: #33709
Authored-by: Nic Crane <[email protected]>
Signed-off-by: Nic Crane <[email protected]>
---
r/R/dplyr-join.R | 6 ++----
r/man/arrow-package.Rd | 2 +-
2 files changed, 3 insertions(+), 5 deletions(-)
diff --git a/r/R/dplyr-join.R b/r/R/dplyr-join.R
index 2ba3c307c1..39237f574b 100644
--- a/r/R/dplyr-join.R
+++ b/r/R/dplyr-join.R
@@ -116,9 +116,8 @@ semi_join.arrow_dplyr_query <- function(x,
y,
by = NULL,
copy = FALSE,
- suffix = c(".x", ".y"),
...) {
- do_join(x, y, by, copy, suffix, ..., join_type = "LEFT_SEMI")
+ do_join(x, y, by, copy, suffix = c(".x", ".y"), ..., join_type = "LEFT_SEMI")
}
semi_join.Dataset <- semi_join.ArrowTabular <- semi_join.RecordBatchReader <-
semi_join.arrow_dplyr_query
@@ -126,9 +125,8 @@ anti_join.arrow_dplyr_query <- function(x,
y,
by = NULL,
copy = FALSE,
- suffix = c(".x", ".y"),
...) {
- do_join(x, y, by, copy, suffix, ..., join_type = "LEFT_ANTI")
+ do_join(x, y, by, copy, suffix = c(".x", ".y"), ..., join_type = "LEFT_ANTI")
}
anti_join.Dataset <- anti_join.ArrowTabular <- anti_join.RecordBatchReader <-
anti_join.arrow_dplyr_query
diff --git a/r/man/arrow-package.Rd b/r/man/arrow-package.Rd
index b6cf0509e3..db6bb8fa38 100644
--- a/r/man/arrow-package.Rd
+++ b/r/man/arrow-package.Rd
@@ -13,7 +13,7 @@ Useful links:
\itemize{
\item \url{https://github.com/apache/arrow/}
\item \url{https://arrow.apache.org/docs/r/}
- \item Report bugs at
\url{https://issues.apache.org/jira/projects/ARROW/issues}
+ \item Report bugs at \url{https://github.com/apache/arrow/issues}
}
}
