This is an automated email from the ASF dual-hosted git repository.

kou pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/master by this push:
     new 717d4fb770 GH-34094: [C++] Increase Boost minimum version for clang >= 
16 (#34100)
717d4fb770 is described below

commit 717d4fb7701f88961bf0b46a3bede1e72f45a19f
Author: Jacob Wujciak-Jens <[email protected]>
AuthorDate: Fri Feb 10 06:23:22 2023 +0100

    GH-34094: [C++] Increase Boost minimum version for clang >= 16 (#34100)
    
    ### Rationale for this change
    
    Build fails with older Boost on Clang >= 16
    
    ### Are there any user-facing changes?
    No our dependency management will download the required Boost version if it 
is not installed on the system.
    * Closes: #34094
    
    Lead-authored-by: Jacob Wujciak-Jens <[email protected]>
    Co-authored-by: Sutou Kouhei <[email protected]>
    Co-authored-by: Sutou Kouhei <[email protected]>
    Co-authored-by: Neal Richardson <[email protected]>
    Signed-off-by: Sutou Kouhei <[email protected]>
---
 cpp/cmake_modules/ThirdpartyToolchain.cmake | 7 ++++++-
 1 file changed, 6 insertions(+), 1 deletion(-)

diff --git a/cpp/cmake_modules/ThirdpartyToolchain.cmake 
b/cpp/cmake_modules/ThirdpartyToolchain.cmake
index 58fd1de3ed..50c9cd2136 100644
--- a/cpp/cmake_modules/ThirdpartyToolchain.cmake
+++ b/cpp/cmake_modules/ThirdpartyToolchain.cmake
@@ -1057,7 +1057,12 @@ macro(build_boost)
   set(BOOST_VENDORED TRUE)
 endmacro()
 
-if(ARROW_BUILD_TESTS)
+if(CMAKE_CXX_COMPILER_ID STREQUAL "Clang" AND CMAKE_CXX_COMPILER_VERSION 
VERSION_GREATER
+                                              15)
+  # GH-34094 Older versions of Boost use the deprecated std::unary_function in
+  # boost/container_hash/hash.hpp and support for that was removed in clang 16
+  set(ARROW_BOOST_REQUIRED_VERSION "1.81")
+elseif(ARROW_BUILD_TESTS)
   set(ARROW_BOOST_REQUIRED_VERSION "1.64")
 else()
   set(ARROW_BOOST_REQUIRED_VERSION "1.58")

Reply via email to