This is an automated email from the ASF dual-hosted git repository.
zeroshade pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/master by this push:
new 266f166680 GH-34055: [Go][CI] Add test run in CI that uses noasm tag
(#34167)
266f166680 is described below
commit 266f16668050d2c901328c11a6da2b31b01ea302
Author: Matt Topol <[email protected]>
AuthorDate: Tue Feb 14 13:44:51 2023 -0500
GH-34055: [Go][CI] Add test run in CI that uses noasm tag (#34167)
### Rationale for this change
A bug was found in the `noasm` build for the Go lib in #34044 so adding a
CI run with the `noasm` tag should prevent that from happening again in the
future.
### What changes are included in this PR?
Updating the `go_test.sh` script to allow for an env var to tell it to add
the `noasm` tag to the `go test` command
Updating go.yml to add a `noasm` CI run
### Are there any user-facing changes?
No
* Closes: #34055
Authored-by: Matt Topol <[email protected]>
Signed-off-by: Matt Topol <[email protected]>
---
ci/scripts/go_test.sh | 10 +++++-----
1 file changed, 5 insertions(+), 5 deletions(-)
diff --git a/ci/scripts/go_test.sh b/ci/scripts/go_test.sh
index e0a632dc06..bad2ffe619 100755
--- a/ci/scripts/go_test.sh
+++ b/ci/scripts/go_test.sh
@@ -66,17 +66,14 @@ if [[ -n "${ARROW_GO_TESTCGO}" ]]; then
TAGS="${TAGS},ccalloc"
fi
-
# the cgo implementation of the c data interface requires the "test"
# tag in order to run its tests so that the testing functions implemented
# in .c files don't get included in non-test builds.
go test $testargs -tags $TAGS ./...
-# only test compute when Go is >= 1.18
-if verlte "1.18" "${ver#go}"; then
- go test $testargs -tags $TAGS ./compute/...
-fi
+# run it again but with the noasm tag
+go test $testargs -tags $TAGS,noasm ./...
popd
@@ -86,4 +83,7 @@ pushd ${source_dir}/parquet
go test $testargs -tags assert ./...
+# run the tests again but with the noasm tag
+go test $testargs -tags assert,noasm ./...
+
popd
