[arrow-rs] branch master updated: Update MIRI for split crates (#2594) (#3754)

[tustvold]

This is an automated email from the ASF dual-hosted git repository.

tustvold pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow-rs.git


The following commit(s) were added to refs/heads/master by this push:
     new 350867436 Update MIRI for split crates (#2594) (#3754)
350867436 is described below

commit 350867436ab3477bafd7008355286378ab37045f
Author: Raphael Taylor-Davies <1781103+tustv...@users.noreply.github.com>
AuthorDate: Thu Feb 23 16:40:00 2023 +0000

    Update MIRI for split crates (#2594) (#3754)
---
 .github/workflows/miri.sh              | 5 ++++-
 arrow-array/src/array/boolean_array.rs | 1 +
 arrow-array/src/array/run_array.rs     | 2 ++
 arrow-array/src/run_iterator.rs        | 1 +
 arrow-buffer/src/bigint.rs             | 2 +-
 5 files changed, 9 insertions(+), 2 deletions(-)

diff --git a/.github/workflows/miri.sh b/.github/workflows/miri.sh
index 56da5c5c5..3323bd099 100755
--- a/.github/workflows/miri.sh
+++ b/.github/workflows/miri.sh
@@ -14,4 +14,7 @@ cargo miri setup
 cargo clean
 
 echo "Starting Arrow MIRI run..."
-cargo miri test -p arrow -- --skip csv --skip ipc --skip json
+cargo miri test -p arrow-buffer
+cargo miri test -p arrow-data --features ffi
+cargo miri test -p arrow-schema --features ffi
+cargo miri test -p arrow-array
diff --git a/arrow-array/src/array/boolean_array.rs 
b/arrow-array/src/array/boolean_array.rs
index 428a721dd..8d1296c66 100644
--- a/arrow-array/src/array/boolean_array.rs
+++ b/arrow-array/src/array/boolean_array.rs
@@ -542,6 +542,7 @@ mod tests {
     }
 
     #[test]
+    #[cfg_attr(miri, ignore)] // Takes too long
     fn test_true_false_count() {
         let mut rng = thread_rng();
 
diff --git a/arrow-array/src/array/run_array.rs 
b/arrow-array/src/array/run_array.rs
index 9dba3ddab..126aefde9 100644
--- a/arrow-array/src/array/run_array.rs
+++ b/arrow-array/src/array/run_array.rs
@@ -881,6 +881,7 @@ mod tests {
     }
 
     #[test]
+    #[cfg_attr(miri, ignore)] // Takes too long
     fn test_get_physical_indices() {
         // Test for logical lengths starting from 10 to 250 increasing by 10
         for logical_len in (0..250).step_by(10) {
@@ -917,6 +918,7 @@ mod tests {
     }
 
     #[test]
+    #[cfg_attr(miri, ignore)] // Takes too long
     fn test_get_physical_indices_sliced() {
         let total_len = 80;
         let input_array = build_input_array(total_len);
diff --git a/arrow-array/src/run_iterator.rs b/arrow-array/src/run_iterator.rs
index fbf173b1d..44cb59ac7 100644
--- a/arrow-array/src/run_iterator.rs
+++ b/arrow-array/src/run_iterator.rs
@@ -349,6 +349,7 @@ mod tests {
     }
 
     #[test]
+    #[cfg_attr(miri, ignore)] // Takes too long
     fn test_sliced_run_array_iterator() {
         let total_len = 80;
         let input_array = build_input_array(total_len);
diff --git a/arrow-buffer/src/bigint.rs b/arrow-buffer/src/bigint.rs
index 0d404df16..421a7bdd0 100644
--- a/arrow-buffer/src/bigint.rs
+++ b/arrow-buffer/src/bigint.rs
@@ -549,7 +549,7 @@ impl ToPrimitive for i256 {
     }
 }
 
-#[cfg(test)]
+#[cfg(all(test, not(miri)))] // llvm.x86.subborrow.64 not supported by MIRI
 mod tests {
     use super::*;
     use num::{BigInt, FromPrimitive, Signed, ToPrimitive};