This is an automated email from the ASF dual-hosted git repository.

agrove pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-ballista.git


The following commit(s) were added to refs/heads/main by this push:
     new 9a6ec0a8 [minor] remove todo (#683)
9a6ec0a8 is described below

commit 9a6ec0a8e6fdb2bfc049499fcd79e5c506e50ddc
Author: Yang Jiang <[email protected]>
AuthorDate: Fri Feb 24 19:49:14 2023 +0800

    [minor] remove todo (#683)
---
 ballista/core/src/execution_plans/shuffle_writer.rs | 5 +----
 1 file changed, 1 insertion(+), 4 deletions(-)

diff --git a/ballista/core/src/execution_plans/shuffle_writer.rs 
b/ballista/core/src/execution_plans/shuffle_writer.rs
index 54db511a..443f8517 100644
--- a/ballista/core/src/execution_plans/shuffle_writer.rs
+++ b/ballista/core/src/execution_plans/shuffle_writer.rs
@@ -219,10 +219,7 @@ impl ShuffleWriterExec {
                         partitioner.partition(
                             input_batch,
                             |output_partition, output_batch| {
-                                // write non-empty batch out
-
-                                // TODO optimize so we don't write or fetch 
empty partitions
-                                // if output_batch.num_rows() > 0 {
+                                // partition func in datafusion make sure not 
write empty output_batch.
                                 let timer = write_metrics.write_time.timer();
                                 match &mut writers[output_partition] {
                                     Some(w) => {

Reply via email to