This is an automated email from the ASF dual-hosted git repository.
zeroshade pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/main by this push:
new ce0d20c06a GH-34629: [Go] Fix transpose_ints to work on
riscv64-freebsd (#34647)
ce0d20c06a is described below
commit ce0d20c06aeb5c484888422cb4ce42e4d24c588c
Author: Matt Topol <[email protected]>
AuthorDate: Wed Mar 22 12:58:16 2023 -0400
GH-34629: [Go] Fix transpose_ints to work on riscv64-freebsd (#34647)
### Rationale for this change
Protecting the Go arrow packages from failing on new architectures by
ensuring the pure go implementation gets loaded for any architecture that isn't
one of the explicit ones we have assembly for.
### What changes are included in this PR?
changing the go build constraint
* Closes: #34629
Authored-by: Matt Topol <[email protected]>
Signed-off-by: Matt Topol <[email protected]>
---
go/internal/utils/endians_default.go | 1 -
go/internal/utils/min_max_amd64.go | 1 -
go/internal/utils/min_max_arm64.go | 1 -
go/internal/utils/min_max_avx2_amd64.go | 1 -
go/internal/utils/min_max_neon_arm64.go | 2 +-
go/internal/utils/min_max_noasm.go | 1 -
go/internal/utils/min_max_ppc64le.go | 1 -
go/internal/utils/min_max_s390x.go | 1 -
go/internal/utils/min_max_sse4_amd64.go | 1 -
go/internal/utils/transpose_ints_amd64.go | 1 -
go/internal/utils/transpose_ints_arm64.go | 1 -
go/internal/utils/transpose_ints_avx2_amd64.go | 1 -
go/internal/utils/transpose_ints_noasm.go | 3 +--
go/internal/utils/transpose_ints_ppc64le.go | 1 -
go/internal/utils/transpose_ints_s390x.go | 1 -
go/internal/utils/transpose_ints_sse4_amd64.go | 1 -
go/internal/utils/transpose_ints_test.go | 1 -
17 files changed, 2 insertions(+), 18 deletions(-)
diff --git a/go/internal/utils/endians_default.go
b/go/internal/utils/endians_default.go
index 28ea6d8287..5fd257f52e 100644
--- a/go/internal/utils/endians_default.go
+++ b/go/internal/utils/endians_default.go
@@ -15,7 +15,6 @@
// limitations under the License.
//go:build !s390x
-// +build !s390x
package utils
diff --git a/go/internal/utils/min_max_amd64.go
b/go/internal/utils/min_max_amd64.go
index 9c3c28718e..5fccddbee2 100644
--- a/go/internal/utils/min_max_amd64.go
+++ b/go/internal/utils/min_max_amd64.go
@@ -15,7 +15,6 @@
// limitations under the License.
//go:build !noasm
-// +build !noasm
package utils
diff --git a/go/internal/utils/min_max_arm64.go
b/go/internal/utils/min_max_arm64.go
index 279488c9ad..7404e95d96 100644
--- a/go/internal/utils/min_max_arm64.go
+++ b/go/internal/utils/min_max_arm64.go
@@ -15,7 +15,6 @@
// limitations under the License.
//go:build !noasm
-// +build !noasm
package utils
diff --git a/go/internal/utils/min_max_avx2_amd64.go
b/go/internal/utils/min_max_avx2_amd64.go
index 3e4466f03b..af6726243d 100644
--- a/go/internal/utils/min_max_avx2_amd64.go
+++ b/go/internal/utils/min_max_avx2_amd64.go
@@ -15,7 +15,6 @@
// limitations under the License.
//go:build !noasm
-// +build !noasm
package utils
diff --git a/go/internal/utils/min_max_neon_arm64.go
b/go/internal/utils/min_max_neon_arm64.go
index db89af4be6..f9d3c44e37 100755
--- a/go/internal/utils/min_max_neon_arm64.go
+++ b/go/internal/utils/min_max_neon_arm64.go
@@ -14,7 +14,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.
-// +build !noasm
+//go:build !noasm
package utils
diff --git a/go/internal/utils/min_max_noasm.go
b/go/internal/utils/min_max_noasm.go
index c2030d24d6..19c24b590b 100644
--- a/go/internal/utils/min_max_noasm.go
+++ b/go/internal/utils/min_max_noasm.go
@@ -15,7 +15,6 @@
// limitations under the License.
//go:build noasm
-// +build noasm
package utils
diff --git a/go/internal/utils/min_max_ppc64le.go
b/go/internal/utils/min_max_ppc64le.go
index ed1b0e6934..ffd2db006d 100644
--- a/go/internal/utils/min_max_ppc64le.go
+++ b/go/internal/utils/min_max_ppc64le.go
@@ -15,7 +15,6 @@
// limitations under the License.
//go:build !noasm
-// +build !noasm
package utils
diff --git a/go/internal/utils/min_max_s390x.go
b/go/internal/utils/min_max_s390x.go
index ed1b0e6934..ffd2db006d 100644
--- a/go/internal/utils/min_max_s390x.go
+++ b/go/internal/utils/min_max_s390x.go
@@ -15,7 +15,6 @@
// limitations under the License.
//go:build !noasm
-// +build !noasm
package utils
diff --git a/go/internal/utils/min_max_sse4_amd64.go
b/go/internal/utils/min_max_sse4_amd64.go
index c886cbaaf2..1e12a8d178 100644
--- a/go/internal/utils/min_max_sse4_amd64.go
+++ b/go/internal/utils/min_max_sse4_amd64.go
@@ -15,7 +15,6 @@
// limitations under the License.
//go:build !noasm
-// +build !noasm
package utils
diff --git a/go/internal/utils/transpose_ints_amd64.go
b/go/internal/utils/transpose_ints_amd64.go
index 0f7c252979..d4433d3687 100644
--- a/go/internal/utils/transpose_ints_amd64.go
+++ b/go/internal/utils/transpose_ints_amd64.go
@@ -17,7 +17,6 @@
// limitations under the License.
//go:build !noasm
-// +build !noasm
package utils
diff --git a/go/internal/utils/transpose_ints_arm64.go
b/go/internal/utils/transpose_ints_arm64.go
index 2650cebe75..cc957cdaa9 100644
--- a/go/internal/utils/transpose_ints_arm64.go
+++ b/go/internal/utils/transpose_ints_arm64.go
@@ -17,7 +17,6 @@
// limitations under the License.
//go:build !noasm
-// +build !noasm
package utils
diff --git a/go/internal/utils/transpose_ints_avx2_amd64.go
b/go/internal/utils/transpose_ints_avx2_amd64.go
index f2c73354a9..f1421ddf5e 100644
--- a/go/internal/utils/transpose_ints_avx2_amd64.go
+++ b/go/internal/utils/transpose_ints_avx2_amd64.go
@@ -17,7 +17,6 @@
// limitations under the License.
//go:build !noasm
-// +build !noasm
package utils
diff --git a/go/internal/utils/transpose_ints_noasm.go
b/go/internal/utils/transpose_ints_noasm.go
index b385427394..461aaf31fb 100644
--- a/go/internal/utils/transpose_ints_noasm.go
+++ b/go/internal/utils/transpose_ints_noasm.go
@@ -16,8 +16,7 @@
// See the License for the specific language governing permissions and
// limitations under the License.
-//go:build noasm
-// +build noasm
+//go:build noasm || (!amd64 && !arm64 && !s390x && !ppc64le)
package utils
diff --git a/go/internal/utils/transpose_ints_ppc64le.go
b/go/internal/utils/transpose_ints_ppc64le.go
index 2650cebe75..cc957cdaa9 100644
--- a/go/internal/utils/transpose_ints_ppc64le.go
+++ b/go/internal/utils/transpose_ints_ppc64le.go
@@ -17,7 +17,6 @@
// limitations under the License.
//go:build !noasm
-// +build !noasm
package utils
diff --git a/go/internal/utils/transpose_ints_s390x.go
b/go/internal/utils/transpose_ints_s390x.go
index 2650cebe75..cc957cdaa9 100644
--- a/go/internal/utils/transpose_ints_s390x.go
+++ b/go/internal/utils/transpose_ints_s390x.go
@@ -17,7 +17,6 @@
// limitations under the License.
//go:build !noasm
-// +build !noasm
package utils
diff --git a/go/internal/utils/transpose_ints_sse4_amd64.go
b/go/internal/utils/transpose_ints_sse4_amd64.go
index edaa27d708..241ca74a76 100644
--- a/go/internal/utils/transpose_ints_sse4_amd64.go
+++ b/go/internal/utils/transpose_ints_sse4_amd64.go
@@ -17,7 +17,6 @@
// limitations under the License.
//go:build !noasm
-// +build !noasm
package utils
diff --git a/go/internal/utils/transpose_ints_test.go
b/go/internal/utils/transpose_ints_test.go
index ac94369daf..f6e6b8d3e1 100644
--- a/go/internal/utils/transpose_ints_test.go
+++ b/go/internal/utils/transpose_ints_test.go
@@ -15,7 +15,6 @@
// limitations under the License.
//go:build !noasm
-// +build !noasm
package utils_test
