This is an automated email from the ASF dual-hosted git repository.
tustvold pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow-rs.git
The following commit(s) were added to refs/heads/master by this push:
new 3582c55d2 feat: Support dyn_compare_scalar for Decimal256 (#4084)
3582c55d2 is described below
commit 3582c55d292e5436b184d5238475330d379210ca
Author: Igor Izvekov <[email protected]>
AuthorDate: Sat Apr 15 00:22:39 2023 +0300
feat: Support dyn_compare_scalar for Decimal256 (#4084)
* feat: Support dyn_compare_scalar for Decimal256
* feat: add test_decimal256_scalar_i256
---
arrow-ord/src/comparison.rs | 128 ++++++++++++++++++++++++++++++++++++++++++++
1 file changed, 128 insertions(+)
diff --git a/arrow-ord/src/comparison.rs b/arrow-ord/src/comparison.rs
index 2927354da..b9ffddd5e 100644
--- a/arrow-ord/src/comparison.rs
+++ b/arrow-ord/src/comparison.rs
@@ -26,6 +26,7 @@
use arrow_array::cast::*;
use arrow_array::types::*;
use arrow_array::*;
+use arrow_buffer::i256;
use arrow_buffer::{bit_util, BooleanBuffer, Buffer, MutableBuffer, NullBuffer};
use arrow_data::ArrayData;
use arrow_schema::{ArrowError, DataType, IntervalUnit, TimeUnit};
@@ -517,6 +518,11 @@ macro_rules! dyn_compare_scalar {
let left = as_primitive_array::<Decimal128Type>($LEFT);
$OP::<Decimal128Type>(left, right)
}
+ DataType::Decimal256(_, _) => {
+ let right = try_to_type!($RIGHT, to_i128)?;
+ let left = as_primitive_array::<Decimal256Type>($LEFT);
+ $OP::<Decimal256Type>(left, i256::from_i128(right))
+ }
DataType::Date32 => {
let right = try_to_type!($RIGHT, to_i32)?;
let left = as_primitive_array::<Date32Type>($LEFT);
@@ -6165,6 +6171,128 @@ mod tests {
assert_eq!(e, r);
}
+ #[test]
+ fn test_decimal256_scalar_i128() {
+ let a = Decimal256Array::from_iter_values(
+ [1, 2, 3, 4, 5].into_iter().map(i256::from_i128),
+ );
+ let b = i256::from_i128(3);
+ // array eq scalar
+ let e = BooleanArray::from(
+ vec![Some(false), Some(false), Some(true), Some(false),
Some(false)],
+ );
+ let r = eq_scalar(&a, b).unwrap();
+ assert_eq!(e, r);
+ let r = eq_dyn_scalar(&a, b).unwrap();
+ assert_eq!(e, r);
+
+ // array neq scalar
+ let e = BooleanArray::from(
+ vec![Some(true), Some(true), Some(false), Some(true), Some(true)],
+ );
+ let r = neq_scalar(&a, b).unwrap();
+ assert_eq!(e, r);
+ let r = neq_dyn_scalar(&a, b).unwrap();
+ assert_eq!(e, r);
+
+ // array lt scalar
+ let e = BooleanArray::from(
+ vec![Some(true), Some(true), Some(false), Some(false),
Some(false)],
+ );
+ let r = lt_scalar(&a, b).unwrap();
+ assert_eq!(e, r);
+ let r = lt_dyn_scalar(&a, b).unwrap();
+ assert_eq!(e, r);
+
+ // array lt_eq scalar
+ let e = BooleanArray::from(
+ vec![Some(true), Some(true), Some(true), Some(false), Some(false)],
+ );
+ let r = lt_eq_scalar(&a, b).unwrap();
+ assert_eq!(e, r);
+ let r = lt_eq_dyn_scalar(&a, b).unwrap();
+ assert_eq!(e, r);
+
+ // array gt scalar
+ let e = BooleanArray::from(
+ vec![Some(false), Some(false), Some(false), Some(true),
Some(true)],
+ );
+ let r = gt_scalar(&a, b).unwrap();
+ assert_eq!(e, r);
+ let r = gt_dyn_scalar(&a, b).unwrap();
+ assert_eq!(e, r);
+
+ // array gt_eq scalar
+ let e = BooleanArray::from(
+ vec![Some(false), Some(false), Some(true), Some(true), Some(true)],
+ );
+ let r = gt_eq_scalar(&a, b).unwrap();
+ assert_eq!(e, r);
+ let r = gt_eq_dyn_scalar(&a, b).unwrap();
+ assert_eq!(e, r);
+ }
+
+ #[test]
+ fn test_decimal256_scalar_i256() {
+ let a = Decimal256Array::from_iter_values(
+ [1, 2, 3, 4, 5].into_iter().map(i256::from_i128),
+ );
+ let b = i256::MAX;
+ // array eq scalar
+ let e = BooleanArray::from(
+ vec![Some(false), Some(false), Some(false), Some(false),
Some(false)],
+ );
+ let r = eq_scalar(&a, b).unwrap();
+ assert_eq!(e, r);
+ let r = eq_dyn_scalar(&a, b).is_err();
+ assert!(r);
+
+ // array neq scalar
+ let e = BooleanArray::from(
+ vec![Some(true), Some(true), Some(true), Some(true), Some(true)],
+ );
+ let r = neq_scalar(&a, b).unwrap();
+ assert_eq!(e, r);
+ let r = neq_dyn_scalar(&a, b).is_err();
+ assert!(r);
+
+ // array lt scalar
+ let e = BooleanArray::from(
+ vec![Some(true), Some(true), Some(true), Some(true), Some(true)],
+ );
+ let r = lt_scalar(&a, b).unwrap();
+ assert_eq!(e, r);
+ let r = lt_dyn_scalar(&a, b).is_err();
+ assert!(r);
+
+ // array lt_eq scalar
+ let e = BooleanArray::from(
+ vec![Some(true), Some(true), Some(true), Some(true), Some(true)],
+ );
+ let r = lt_eq_scalar(&a, b).unwrap();
+ assert_eq!(e, r);
+ let r = lt_eq_dyn_scalar(&a, b).is_err();
+ assert!(r);
+
+ // array gt scalar
+ let e = BooleanArray::from(
+ vec![Some(false), Some(false), Some(false), Some(false),
Some(false)],
+ );
+ let r = gt_scalar(&a, b).unwrap();
+ assert_eq!(e, r);
+ let r = gt_dyn_scalar(&a, b).is_err();
+ assert!(r);
+
+ // array gt_eq scalar
+ let e = BooleanArray::from(
+ vec![Some(false), Some(false), Some(false), Some(false),
Some(false)],
+ );
+ let r = gt_eq_scalar(&a, b).unwrap();
+ assert_eq!(e, r);
+ let r = gt_eq_dyn_scalar(&a, b).is_err();
+ assert!(r);
+ }
+
#[test]
#[cfg(not(feature = "simd"))]
fn test_floating_zeros() {
