This is an automated email from the ASF dual-hosted git repository.
apitrou pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/main by this push:
new df5f67d5a8 MINOR: [C++] Add missing RunEndEncodedType dtor (#35340)
df5f67d5a8 is described below
commit df5f67d5a80c676417c38563743e72b17e854f1f
Author: Felipe Oliveira Carvalho <[email protected]>
AuthorDate: Wed May 10 12:05:00 2023 -0300
MINOR: [C++] Add missing RunEndEncodedType dtor (#35340)
### Rationale for this change
Avoid problems with LTO compilation (see commit 24da3be9560c5)
### What changes are included in this PR?
Definition of a virtual dtor for RunEndEncodedType.
### Are these changes tested?
N/A.
Authored-by: Felipe Oliveira Carvalho <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
---
cpp/src/arrow/type.cc | 2 ++
cpp/src/arrow/type.h | 1 +
2 files changed, 3 insertions(+)
diff --git a/cpp/src/arrow/type.cc b/cpp/src/arrow/type.cc
index 4804570bdf..606b231f6f 100644
--- a/cpp/src/arrow/type.cc
+++ b/cpp/src/arrow/type.cc
@@ -799,6 +799,8 @@
RunEndEncodedType::RunEndEncodedType(std::shared_ptr<DataType> run_end_type,
std::make_shared<Field>("values", std::move(value_type), true)};
}
+RunEndEncodedType::~RunEndEncodedType() = default;
+
std::string RunEndEncodedType::ToString() const {
std::stringstream s;
s << name() << "<run_ends: " << run_end_type()->ToString()
diff --git a/cpp/src/arrow/type.h b/cpp/src/arrow/type.h
index 560805535d..a3e78eeb72 100644
--- a/cpp/src/arrow/type.h
+++ b/cpp/src/arrow/type.h
@@ -1232,6 +1232,7 @@ class ARROW_EXPORT RunEndEncodedType : public NestedType {
explicit RunEndEncodedType(std::shared_ptr<DataType> run_end_type,
std::shared_ptr<DataType> value_type);
+ ~RunEndEncodedType() override;
DataTypeLayout layout() const override {
// A lot of existing code expects at least one buffer
