[arrow] branch main updated: GH-35651: [C++] Don't use self-move with MinGW (#35653)

[apitrou]

This is an automated email from the ASF dual-hosted git repository.

apitrou pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/main by this push:
     new 3e4eaa917f GH-35651: [C++] Don't use self-move with MinGW (#35653)
3e4eaa917f is described below

commit 3e4eaa917fa9b09a923d255adee520aa68a4e78c
Author: Sutou Kouhei <k...@clear-code.com>
AuthorDate: Thu May 18 20:36:51 2023 +0900

    GH-35651: [C++] Don't use self-move with MinGW (#35653)
    
    ### Rationale for this change
    
    Because MinGW g++ reports a warning:
    
    ```text
    D:/a/arrow/arrow/cpp/src/arrow/util/small_vector_test.cc:417:22:
    warning: moving 'moved_moved_ints' of type
    'arrow::internal::TestSmallStaticVector<
      arrow::internal::VectorIntLikeParam<
        arrow::internal::StaticVectorTraits, arrow::MoveOnlyDataType> 
>::IntVectorType<5>'
    {aka 'arrow::internal::StaticVectorImpl<
            arrow::MoveOnlyDataType, 5, 
arrow::internal::StaticVectorStorage<arrow::MoveOnlyDataType, 5, true> >'}
    to itself [-Wself-move]
      417 |     moved_moved_ints = std::move(moved_moved_ints);
          |     ~~~~~~~~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~
    D:/a/arrow/arrow/cpp/src/arrow/util/small_vector_test.cc:417:22: note: 
remove 'std::move' call
    ```
    
    ### What changes are included in this PR?
    
    Disable self-move code only for MinGW.
    
    ### Are these changes tested?
    
    Yes.
    
    ### Are there any user-facing changes?
    
    No.
    * Closes: #35651
    
    Authored-by: Sutou Kouhei <k...@clear-code.com>
    Signed-off-by: Antoine Pitrou <anto...@python.org>
---
 cpp/src/arrow/util/small_vector_test.cc | 2 ++
 1 file changed, 2 insertions(+)

diff --git a/cpp/src/arrow/util/small_vector_test.cc 
b/cpp/src/arrow/util/small_vector_test.cc
index f9ec5fedfe..d450e2084a 100644
--- a/cpp/src/arrow/util/small_vector_test.cc
+++ b/cpp/src/arrow/util/small_vector_test.cc
@@ -413,10 +413,12 @@ class TestSmallStaticVector : public ::testing::Test {
     ASSERT_EQ(moved_moved_ints.size(), 5);
     EXPECT_THAT(moved_moved_ints, ElementsAre(4, 5, 6, 7, 8));
 
+#ifndef __MINGW32__
     // Move into itself
     moved_moved_ints = std::move(moved_moved_ints);
     ASSERT_EQ(moved_moved_ints.size(), 5);
     EXPECT_THAT(moved_moved_ints, ElementsAre(4, 5, 6, 7, 8));
+#endif
   }
 
   void TestMove() {