This is an automated email from the ASF dual-hosted git repository.

apitrou pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/main by this push:
     new ce095e4618 GH-35712: [C++][CI] MacOS Disable ASSERT_DEATH in 
arrow-array-test (#35724)
ce095e4618 is described below

commit ce095e4618d68503b7934739f90e67b5f1f494e6
Author: mwish <[email protected]>
AuthorDate: Tue May 23 23:55:01 2023 +0800

    GH-35712: [C++][CI] MacOS Disable ASSERT_DEATH in arrow-array-test (#35724)
    
    
    
    ### Rationale for this change
    
    Disable ASSERT_DEATH in MacOS. According to 
https://github.com/apache/arrow/issues/35712, it would making CI extremely slow.
    
    ### What changes are included in this PR?
    
    Disable test in macos
    
    ### Are these changes tested?
    
    no
    
    ### Are there any user-facing changes?
    
    no
    
    * Closes: #35712
    
    Authored-by: mwish <[email protected]>
    Signed-off-by: Antoine Pitrou <[email protected]>
---
 cpp/src/arrow/array/array_dict_test.cc | 3 +++
 1 file changed, 3 insertions(+)

diff --git a/cpp/src/arrow/array/array_dict_test.cc 
b/cpp/src/arrow/array/array_dict_test.cc
index 54cf3a73d6..3c1a1aaa86 100644
--- a/cpp/src/arrow/array/array_dict_test.cc
+++ b/cpp/src/arrow/array/array_dict_test.cc
@@ -1129,12 +1129,15 @@ TEST(TestDictionary, Validate) {
   arr = std::make_shared<DictionaryArray>(dict_type, indices, 
MakeArray(invalid_data));
   ASSERT_RAISES(Invalid, arr->ValidateFull());
 
+#if !defined(__APPLE__)
+  // GH-35712: ASSERT_DEATH would make testing slow on MacOS.
   ASSERT_DEATH(
       {
         std::shared_ptr<Array> null_dict_arr =
             std::make_shared<DictionaryArray>(dict_type, indices, nullptr);
       },
       "");
+#endif
 }
 
 TEST(TestDictionary, FromArrays) {

Reply via email to