This is an automated email from the ASF dual-hosted git repository.

apitrou pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/main by this push:
     new 1bfa241b1c GH-35636: [C++] Extract two expensive test suites from 
compute-vector-test (#36401)
1bfa241b1c is described below

commit 1bfa241b1c9cede71297f5a7516a4c4c1bb8f117
Author: Felipe Oliveira Carvalho <[email protected]>
AuthorDate: Mon Jul 3 14:21:55 2023 -0300

    GH-35636: [C++] Extract two expensive test suites from compute-vector-test 
(#36401)
    
    ### Rationale for this change
    
    `arrow-compute-vector-test` is too big and takes a long time to run because 
of that.
    
    ### What changes are included in this PR?
    
    Extracting two tests.
    
    Timings on my machine (Debug builds with ASAN).
    
    ```
    debug/arrow-compute-vector-test > /dev/null  11.54s user 0.47s system 99% 
cpu 12.023 total
    debug/arrow-compute-vector-sort-test > /dev/null  13.30s user 0.26s system 
99% cpu 13.579 total
    debug/arrow-compute-vector-selection-test > /dev/null  6.97s user 0.22s 
system 99% cpu 7.207 total
    ```
    
    ### Are these changes tested?
    
    Yes.
    
    ### Are there any user-facing changes?
    
    No.
    
    * Closes: #35636
    
    Authored-by: Felipe Oliveira Carvalho <[email protected]>
    Signed-off-by: Antoine Pitrou <[email protected]>
---
 cpp/src/arrow/compute/kernels/CMakeLists.txt | 7 +++++--
 1 file changed, 5 insertions(+), 2 deletions(-)

diff --git a/cpp/src/arrow/compute/kernels/CMakeLists.txt 
b/cpp/src/arrow/compute/kernels/CMakeLists.txt
index 1afeb419c4..a17d6275a7 100644
--- a/cpp/src/arrow/compute/kernels/CMakeLists.txt
+++ b/cpp/src/arrow/compute/kernels/CMakeLists.txt
@@ -73,12 +73,15 @@ add_arrow_compute_test(vector_test
                        vector_hash_test.cc
                        vector_nested_test.cc
                        vector_replace_test.cc
-                       vector_selection_test.cc
-                       vector_sort_test.cc
                        vector_run_end_encode_test.cc
                        select_k_test.cc
                        test_util.cc)
 
+add_arrow_compute_test(vector_sort_test SOURCES vector_sort_test.cc 
test_util.cc)
+
+add_arrow_compute_test(vector_selection_test SOURCES vector_selection_test.cc
+                       test_util.cc)
+
 add_arrow_benchmark(vector_hash_benchmark PREFIX "arrow-compute")
 add_arrow_benchmark(vector_sort_benchmark PREFIX "arrow-compute")
 add_arrow_benchmark(vector_partition_benchmark PREFIX "arrow-compute")

Reply via email to