This is an automated email from the ASF dual-hosted git repository.

kou pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/main by this push:
     new 980f828587 MINOR: [CI] Use GITHUB_PATH instead of GITHUB_ACTIONS to 
detect environment (#36495)
980f828587 is described below

commit 980f8285877fc9d2e1cee655814644c0462737c9
Author: Jacob Wujciak-Jens <[email protected]>
AuthorDate: Thu Jul 6 10:00:53 2023 +0200

    MINOR: [CI] Use GITHUB_PATH instead of GITHUB_ACTIONS to detect environment 
(#36495)
    
    ### Rationale for this change
    
    In #35753 we started passing  GITHUB_ACTIONS into the docker containers for 
better log printing. The sccache script used this var to detect if it was run 
in gha to add sccache to the path. This now causes false positives.
    
    ### What changes are included in this PR?
    
    Use GITHUB_PATH directly instead.
    
    ### Are these changes tested?
    Will trigger crossbow jobs
    
    Authored-by: Jacob Wujciak-Jens <[email protected]>
    Signed-off-by: Sutou Kouhei <[email protected]>
---
 ci/scripts/install_sccache.sh | 2 +-
 1 file changed, 1 insertion(+), 1 deletion(-)

diff --git a/ci/scripts/install_sccache.sh b/ci/scripts/install_sccache.sh
index 2ee3486699..902fb69ec6 100755
--- a/ci/scripts/install_sccache.sh
+++ b/ci/scripts/install_sccache.sh
@@ -61,7 +61,7 @@ fi
 tar -xzvf $SCCACHE_ARCHIVE --strip-component=1 --directory $PREFIX 
--exclude="sccache*/*E*E*"
 chmod u+x $PREFIX/sccache
 
-if [ "${GITHUB_ACTIONS}" = "true" ]; then
+if [ -n "${GITHUB_PATH}" ]; then
     echo "$PREFIX" >> $GITHUB_PATH
     # Add executable for windows as mingw workaround.
     echo "SCCACHE_PATH=$PREFIX/sccache.exe" >> $GITHUB_ENV

Reply via email to