This is an automated email from the ASF dual-hosted git repository.
lidavidm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-adbc.git
The following commit(s) were added to refs/heads/main by this push:
new d2ac2b2f test(c/driver/sqlite): improve coverage for uint, tz (#901)
d2ac2b2f is described below
commit d2ac2b2f275d732843923a528ee4c05dee9400f4
Author: William Ayd <[email protected]>
AuthorDate: Fri Jul 14 08:40:43 2023 -0700
test(c/driver/sqlite): improve coverage for uint, tz (#901)
---
c/driver/sqlite/sqlite_test.cc | 9 +++++----
1 file changed, 5 insertions(+), 4 deletions(-)
diff --git a/c/driver/sqlite/sqlite_test.cc b/c/driver/sqlite/sqlite_test.cc
index f99697d9..3ab21fe3 100644
--- a/c/driver/sqlite/sqlite_test.cc
+++ b/c/driver/sqlite/sqlite_test.cc
@@ -189,12 +189,13 @@ class SqliteStatementTest : public ::testing::Test,
void SetUp() override { ASSERT_NO_FATAL_FAILURE(SetUpTest()); }
void TearDown() override { ASSERT_NO_FATAL_FAILURE(TearDownTest()); }
- void TestSqlIngestUInt64() { GTEST_SKIP() << "Cannot ingest UINT64 (out of
range)"; }
- void TestSqlIngestBinary() { GTEST_SKIP() << "Cannot ingest BINARY (not
implemented)"; }
- void TestSqlIngestTimestampTz() {
- GTEST_SKIP() << "Cannot ingest TIMESTAMP WITH TIMEZONE (not implemented)";
+ void TestSqlIngestUInt64() {
+ std::vector<std::optional<uint64_t>> values = {std::nullopt, 0, INT64_MAX};
+ return TestSqlIngestType(NANOARROW_TYPE_UINT64, values);
}
+ void TestSqlIngestBinary() { GTEST_SKIP() << "Cannot ingest BINARY (not
implemented)"; }
+
protected:
void ValidateIngestedTemporalData(struct ArrowArrayView* values,
enum ArrowTimeUnit unit,