This is an automated email from the ASF dual-hosted git repository.
paleolimbot pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-nanoarrow.git
The following commit(s) were added to refs/heads/main by this push:
new efea22c chore: Update verification action to use a cached Arrow C++
build on all platforms (#265)
efea22c is described below
commit efea22cc4eec237f004449420b6c7ee02732fb8f
Author: Dewey Dunnington <[email protected]>
AuthorDate: Fri Jul 21 17:11:35 2023 -0300
chore: Update verification action to use a cached Arrow C++ build on all
platforms (#265)
Previously this was installing from `apt` on Ubuntu and `brew` on MacOS;
however, the Windows verification was much faster because the arrow
install can be cached. Additionally, the MacOS build was failing due to
something protobuf-related and the minimal build solves that problem
too.
---
.github/workflows/verify.yaml | 38 +++++++++++++-------------------------
1 file changed, 13 insertions(+), 25 deletions(-)
diff --git a/.github/workflows/verify.yaml b/.github/workflows/verify.yaml
index 7fe3150..41560d2 100644
--- a/.github/workflows/verify.yaml
+++ b/.github/workflows/verify.yaml
@@ -76,41 +76,23 @@ jobs:
needs: check
working-directory: src/r
- - name: Cache Windows Arrow C++ Build
- if: matrix.config.label == 'windows'
+ - name: Cache Arrow C++ Build
id: cache-arrow-build
uses: actions/cache@v3
with:
path: arrow
- key: arrow-${{ runner.os }}-3
-
- # For Arrow C++
- - name: Install Arrow C++ (MacOS)
- if: matrix.config.label == 'macos'
- run: brew install apache-arrow
+ key: arrow-${{ runner.os }}-4
- - name: Install Arrow C++ (Debian)
- if: matrix.config.label == 'ubuntu'
- shell: bash
- run: |
- sudo apt-get update
- sudo apt install -y -V ca-certificates lsb-release wget cmake
- wget https://apache.jfrog.io/artifactory/arrow/$(lsb_release --id
--short | tr 'A-Z' 'a-z')/apache-arrow-apt-source-latest-$(lsb_release
--codename --short).deb
- sudo apt-get install -y -V
./apache-arrow-apt-source-latest-$(lsb_release --codename --short).deb
- sudo apt-get update
- sudo apt-get install -y -V libarrow-dev
- rm apache-arrow-apt-*.deb
-
- - name: Build Arrow C++ (Windows)
- if: matrix.config.label == 'windows' &&
steps.cache-arrow-build.outputs.cache-hit != 'true'
+ - name: Build Arrow C++
+ if: steps.cache-arrow-build.outputs.cache-hit != 'true'
shell: bash
run: |
- curl
https://dlcdn.apache.org/arrow/arrow-12.0.0/apache-arrow-12.0.0.tar.gz | \
+ curl
https://dlcdn.apache.org/arrow/arrow-12.0.1/apache-arrow-12.0.1.tar.gz | \
tar -zxf -
mkdir arrow-build && cd arrow-build
- cmake ../apache-arrow-12.0.0/cpp -DCMAKE_INSTALL_PREFIX=../arrow
+ cmake ../apache-arrow-12.0.1/cpp -DCMAKE_INSTALL_PREFIX=../arrow
cmake --build .
- cmake --install . --prefix=../arrow --config=Debug
+ cmake --install . --prefix=../arrow
cd ..
- name: Set CMake options (Windows)
@@ -119,6 +101,12 @@ jobs:
run: |
echo "NANOARROW_CMAKE_OPTIONS=${NANOARROW_CMAKE_OPTIONS}
-DArrow_DIR=$(pwd -W)/arrow/lib/cmake/Arrow -Dgtest_force_shared_crt=ON" >>
$GITHUB_ENV
+ - name: Set CMake options (POSIX)
+ if: matrix.config.label != 'windows'
+ shell: bash
+ run: |
+ echo "NANOARROW_CMAKE_OPTIONS=${NANOARROW_CMAKE_OPTIONS}
-DArrow_DIR=$(pwd)/arrow/lib/cmake/Arrow" >> $GITHUB_ENV
+
- name: Run dev/release/verify-release-candidate.sh
shell: bash
env: