This is an automated email from the ASF dual-hosted git repository.
kou pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/main by this push:
new 5b744ab0e8 GH-36922: [CI][C++][Windows] Search OpenSSL from PATH
(#36923)
5b744ab0e8 is described below
commit 5b744ab0e854f494f8df145b27dc30236df13221
Author: Sutou Kouhei <[email protected]>
AuthorDate: Fri Jul 28 09:50:29 2023 +0900
GH-36922: [CI][C++][Windows] Search OpenSSL from PATH (#36923)
### Rationale for this change
It seems that OpenSSL install script adds the OpenSSL install folder to
`PATH`:
https://github.com/actions/runner-images/blob/665e71067ff126acea71e7d93715c83db038597f/images/win/scripts/Installers/Install-OpenSSL.ps1#L37
If OpenSSL install folder exists in `PATH`, we don't need to specify
`OPENSSL_ROOT_DIR` explicitly. Because `find_*` such as
[`find_library()`](https://cmake.org/cmake/help/latest/command/find_library.html)
searches path in `PATH` by default:
> On Windows hosts: `<prefix>/lib/<arch>` if
[`CMAKE_LIBRARY_ARCHITECTURE`](https://cmake.org/cmake/help/latest/variable/CMAKE_LIBRARY_ARCHITECTURE.html#variable:CMAKE_LIBRARY_ARCHITECTURE)
is set, and `<prefix>/lib` for each `<prefix>/[s]bin` in `PATH`, and
`<entry>/lib` for other entries in `PATH`.
### What changes are included in this PR?
Remove `OPENSSL_ROOT_DIR`.
### Are these changes tested?
Yes.
### Are there any user-facing changes?
No.
* Closes: #36922
Authored-by: Sutou Kouhei <[email protected]>
Signed-off-by: Sutou Kouhei <[email protected]>
---
.github/workflows/cpp.yml | 2 --
1 file changed, 2 deletions(-)
diff --git a/.github/workflows/cpp.yml b/.github/workflows/cpp.yml
index 63a16c8c11..cd12be1148 100644
--- a/.github/workflows/cpp.yml
+++ b/.github/workflows/cpp.yml
@@ -269,8 +269,6 @@ jobs:
CMAKE_INSTALL_LIBDIR: bin
CMAKE_INSTALL_PREFIX: /usr
CMAKE_UNITY_BUILD: ON
- OPENSSL_ROOT_DIR: >-
- C:\Program Files\OpenSSL-Win64
NPROC: 3
steps:
- name: Disable Crash Dialogs
