This is an automated email from the ASF dual-hosted git repository.

kou pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/main by this push:
     new 839ea601d5 MINOR: [C++] async_until typo fix (#37029)
839ea601d5 is described below

commit 839ea601d5241dde43ee59f667eaceec963977b5
Author: mwish <[email protected]>
AuthorDate: Mon Aug 7 08:41:41 2023 +0800

    MINOR: [C++] async_until typo fix (#37029)
    
    
    
    ### Rationale for this change
    
    Fix typo in `cpp/src/arrow/acero/source_node.cc` and  
`cpp/src/arrow/util/async_util.h`.
    
    ### What changes are included in this PR?
    
    Fix typo in `cpp/src/arrow/acero/source_node.cc` and  
`cpp/src/arrow/util/async_util.h`.
    
    ### Are these changes tested?
    
    no
    
    ### Are there any user-facing changes?
    
    no
    
    Authored-by: mwish <[email protected]>
    Signed-off-by: Sutou Kouhei <[email protected]>
---
 cpp/src/arrow/acero/source_node.cc | 4 ++--
 cpp/src/arrow/util/async_util.h    | 8 ++++----
 2 files changed, 6 insertions(+), 6 deletions(-)

diff --git a/cpp/src/arrow/acero/source_node.cc 
b/cpp/src/arrow/acero/source_node.cc
index ddb062ac00..8060e01f07 100644
--- a/cpp/src/arrow/acero/source_node.cc
+++ b/cpp/src/arrow/acero/source_node.cc
@@ -99,7 +99,7 @@ struct SourceNode : ExecNode, public TracedNode {
       : ExecNode(plan, {}, {}, std::move(output_schema)),
         TracedNode(this),
         generator_(std::move(generator)),
-        ordering_(ordering) {}
+        ordering_(std::move(ordering)) {}
 
   static Result<ExecNode*> Make(ExecPlan* plan, std::vector<ExecNode*> inputs,
                                 const ExecNodeOptions& options) {
@@ -177,7 +177,7 @@ struct SourceNode : ExecNode, public TracedNode {
 
     CallbackOptions options;
     // These options will transfer execution to the desired Executor if 
necessary.
-    // This can happen for in-memory scans where batches didn't require
+    // This can happen for in-memory scans where batches don't require
     // any CPU work to decode. Otherwise, parsing etc should have already
     // been placed us on the desired Executor and no queues will be pushed to.
     options.executor = plan()->query_context()->executor();
diff --git a/cpp/src/arrow/util/async_util.h b/cpp/src/arrow/util/async_util.h
index 2668ae2226..db03719f5e 100644
--- a/cpp/src/arrow/util/async_util.h
+++ b/cpp/src/arrow/util/async_util.h
@@ -58,7 +58,7 @@ namespace util {
 /// finish.  Note, it is not an error to add additional tasks after a 
scheduler has
 /// aborted. These tasks will be ignored and never submitted.  The scheduler 
returns a
 /// future which will complete when all submitted tasks have finished 
executing.  Once all
-/// tasks have been finsihed the scheduler is invalid and should no longer be 
used.
+/// tasks have been finished the scheduler is invalid and should no longer be 
used.
 ///
 /// Task failure (either the synchronous portion or the asynchronous portion) 
will cause
 /// the scheduler to enter an aborted state.  The first such failure will be 
reported in
@@ -117,7 +117,7 @@ class ARROW_EXPORT AsyncTaskScheduler {
   ///
   /// A task's name must remain valid for the duration of the task.  It is 
used for
   /// debugging (e.g. when debugging a deadlock to see which tasks still 
remain) and for
-  /// traceability (the name will be used for spans asigned to the task)
+  /// traceability (the name will be used for spans assigned to the task)
   ///
   /// \return true if the task was submitted or queued, false if the task was 
ignored
   virtual bool AddTask(std::unique_ptr<Task> task) = 0;
@@ -262,7 +262,7 @@ class ARROW_EXPORT ThrottledAsyncTaskScheduler : public 
AsyncTaskScheduler {
     virtual void Pause() = 0;
     /// Resume the throttle
     ///
-    /// Allows taks to be submitted again.  If there is a max_concurrent_cost 
limit then
+    /// Allows task to be submitted again.  If there is a max_concurrent_cost 
limit then
     /// it will still apply.
     virtual void Resume() = 0;
   };
@@ -274,7 +274,7 @@ class ARROW_EXPORT ThrottledAsyncTaskScheduler : public 
AsyncTaskScheduler {
   virtual void Pause() = 0;
   /// Resume the throttle
   ///
-  /// Allows taks to be submitted again.  If there is a max_concurrent_cost 
limit then
+  /// Allows task to be submitted again.  If there is a max_concurrent_cost 
limit then
   /// it will still apply.
   virtual void Resume() = 0;
 

Reply via email to