This is an automated email from the ASF dual-hosted git repository.

kou pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/main by this push:
     new 178b055464 MINOR: [C++] Fix a lint failure (#37048)
178b055464 is described below

commit 178b055464f35f4aeef8d5ddf34fdc15ab5be264
Author: Sutou Kouhei <[email protected]>
AuthorDate: Tue Aug 8 09:31:12 2023 +0900

    MINOR: [C++] Fix a lint failure (#37048)
    
    ### Rationale for this change
    
    GH-37031 had the following lint failure but I merged it. Sorry.
    
    ```text
    FAILED: CMakeFiles/check-format
    cd /tmp/arrow-lint-3lmfc4qt/cpp-build && /usr/local/bin/python 
/arrow/cpp/build-support/run_clang_format.py --clang_format_binary 
/usr/bin/clang-format-14 --exclude_globs 
/arrow/cpp/build-support/lint_exclusions.txt --source_dir /arrow/cpp/src 
--source_dir /arrow/cpp/examples --source_dir /arrow/cpp/tools --quiet
    
    --- /arrow/cpp/src/arrow/acero/aggregate_internal.h
    +++ /arrow/cpp/src/arrow/acero/aggregate_internal.h (after clang format)
    @@ -52,8 +52,8 @@
     // segment-keys is used to refine the partitioning. However, segment-keys 
are different in
     // that they partition only consecutive rows into a single group. Such a 
partition of
     // consecutive rows is called a segment group. For example, consider a 
column X with
    -// values [A, A, B, A] at row-indices [0, 1, 2, 3]. A regular group-by 
aggregation with keys
    -// [X] yields a row-index partitioning [[0, 1, 3], [2]] whereas a 
segmented-group-by
    +// values [A, A, B, A] at row-indices [0, 1, 2, 3]. A regular group-by 
aggregation with
    +// keys [X] yields a row-index partitioning [[0, 1, 3], [2]] whereas a 
segmented-group-by
     // aggregation with segment-keys [X] yields [[0, 1], [2], [3]].
     //
     // The implementation first segments the input using the segment-keys, 
then groups by the
    /arrow/cpp/src/arrow/acero/aggregate_internal.h had clang-format style 
issues
    ```
    
    ### What changes are included in this PR?
    
    I've fixed it by `ninja format`.
    
    ### Are these changes tested?
    
    Yes.
    
    ### Are there any user-facing changes?
    
    No.
    
    Authored-by: Sutou Kouhei <[email protected]>
    Signed-off-by: Sutou Kouhei <[email protected]>
---
 cpp/src/arrow/acero/aggregate_internal.h | 4 ++--
 1 file changed, 2 insertions(+), 2 deletions(-)

diff --git a/cpp/src/arrow/acero/aggregate_internal.h 
b/cpp/src/arrow/acero/aggregate_internal.h
index 744acb1245..72537a7f7e 100644
--- a/cpp/src/arrow/acero/aggregate_internal.h
+++ b/cpp/src/arrow/acero/aggregate_internal.h
@@ -52,8 +52,8 @@
 // segment-keys is used to refine the partitioning. However, segment-keys are 
different in
 // that they partition only consecutive rows into a single group. Such a 
partition of
 // consecutive rows is called a segment group. For example, consider a column 
X with
-// values [A, A, B, A] at row-indices [0, 1, 2, 3]. A regular group-by 
aggregation with keys
-// [X] yields a row-index partitioning [[0, 1, 3], [2]] whereas a 
segmented-group-by
+// values [A, A, B, A] at row-indices [0, 1, 2, 3]. A regular group-by 
aggregation with
+// keys [X] yields a row-index partitioning [[0, 1, 3], [2]] whereas a 
segmented-group-by
 // aggregation with segment-keys [X] yields [[0, 1], [2], [3]].
 //
 // The implementation first segments the input using the segment-keys, then 
groups by the

Reply via email to