This is an automated email from the ASF dual-hosted git repository. dheres pushed a commit to branch hash_agg_spike in repository https://gitbox.apache.org/repos/asf/arrow-datafusion.git
commit ccfd3ce65f2418bd6d284f2d0ead5958c051dbd0 Author: Andrew Lamb <[email protected]> AuthorDate: Sat Jul 1 07:16:26 2023 -0400 comments --- .../physical-expr/src/aggregate/groups_accumulator/accumulate.rs | 4 +++- 1 file changed, 3 insertions(+), 1 deletion(-) diff --git a/datafusion/physical-expr/src/aggregate/groups_accumulator/accumulate.rs b/datafusion/physical-expr/src/aggregate/groups_accumulator/accumulate.rs index 24e4b04661..8ea22acd8a 100644 --- a/datafusion/physical-expr/src/aggregate/groups_accumulator/accumulate.rs +++ b/datafusion/physical-expr/src/aggregate/groups_accumulator/accumulate.rs @@ -74,6 +74,7 @@ pub fn accumulate_all<T, F>( T: ArrowNumericType + Send, F: FnMut(usize, T::Native) + Send, { + // Given performance is critical, assert if the wrong flavor is called assert_eq!( values.null_count(), 0, "Called accumulate_all with nullable array (call accumulate_all_nullable instead)" @@ -108,7 +109,8 @@ pub fn accumulate_all_nullable<T, F>( F: FnMut(usize, T::Native, bool) + Send, { // AAL TODO handle filter values - // TODO combine the null mask from values and opt_filter + + // Given performance is critical, assert if the wrong flavor is called let valids = values .nulls() .expect("Called accumulate_all_nullable with non-nullable array (call accumulate_all instead)");
