This is an automated email from the ASF dual-hosted git repository. alamb pushed a commit to branch alamb-patch-1 in repository https://gitbox.apache.org/repos/asf/arrow-datafusion.git
commit f63bcf7381d83f40fba8755ae4a76d2a186d549b Author: Andrew Lamb <[email protected]> AuthorDate: Sun Aug 13 07:34:26 2023 -0400 Add upstream ticket reference Add doc link reference to https://github.com/apache/arrow-rs/issues/4693 --- datafusion/core/src/datasource/file_format/parquet.rs | 4 ++++ 1 file changed, 4 insertions(+) diff --git a/datafusion/core/src/datasource/file_format/parquet.rs b/datafusion/core/src/datasource/file_format/parquet.rs index c35f59dd4a..de3ec3ffb7 100644 --- a/datafusion/core/src/datasource/file_format/parquet.rs +++ b/datafusion/core/src/datasource/file_format/parquet.rs @@ -604,6 +604,7 @@ impl DisplayAs for ParquetSink { } /// Parses datafusion.execution.parquet.encoding String to a parquet::basic::Encoding +/// TODO use upstream version: <https://github.com/apache/arrow-rs/issues/4693> fn parse_encoding_string(str_setting: &str) -> Result<parquet::basic::Encoding> { let str_setting_lower: &str = &str_setting.to_lowercase(); match str_setting_lower { @@ -667,6 +668,7 @@ fn require_level(codec: &str, level: Option<u32>) -> Result<u32> { } /// Parses datafusion.execution.parquet.compression String to a parquet::basic::Compression +/// TODO use upstream version: <https://github.com/apache/arrow-rs/issues/4693> fn parse_compression_string(str_setting: &str) -> Result<parquet::basic::Compression> { let str_setting_lower: &str = &str_setting.to_lowercase(); let (codec, level) = split_compression_string(str_setting_lower)?; @@ -717,6 +719,7 @@ fn parse_compression_string(str_setting: &str) -> Result<parquet::basic::Compres } } +/// TODO use upstream version: <https://github.com/apache/arrow-rs/issues/4693> fn parse_version_string(str_setting: &str) -> Result<WriterVersion> { let str_setting_lower: &str = &str_setting.to_lowercase(); match str_setting_lower { @@ -729,6 +732,7 @@ fn parse_version_string(str_setting: &str) -> Result<WriterVersion> { } } +/// TODO use upstream version: <https://github.com/apache/arrow-rs/issues/4693> fn parse_statistics_string(str_setting: &str) -> Result<EnabledStatistics> { let str_setting_lower: &str = &str_setting.to_lowercase(); match str_setting_lower {
