This is an automated email from the ASF dual-hosted git repository.
thisisnic pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/main by this push:
new c079dac1bb GH-37384: [R] Set
_R_CHECK_STOP_ON_INVALID_NUMERIC_VERSION_INPUTS_ = TRUE on CI (#37385)
c079dac1bb is described below
commit c079dac1bb112c21e2721008d845b90e6bba94f4
Author: Nic Crane <[email protected]>
AuthorDate: Fri Aug 25 18:15:45 2023 +0100
GH-37384: [R] Set _R_CHECK_STOP_ON_INVALID_NUMERIC_VERSION_INPUTS_ = TRUE
on CI (#37385)
### Rationale for this change
Checks fail on CRAN which don't fail on our CI - we should make them fail
on our CI instead of just issue a warning
### What changes are included in this PR?
Update settings for R builds so these checks raise error not warning
### Are these changes tested?
Nope
### Are there any user-facing changes?
No
* Closes: #37384
Authored-by: Nic Crane <[email protected]>
Signed-off-by: Nic Crane <[email protected]>
---
.github/workflows/r.yml | 3 ++-
ci/scripts/r_test.sh | 2 ++
2 files changed, 4 insertions(+), 1 deletion(-)
diff --git a/.github/workflows/r.yml b/.github/workflows/r.yml
index 277080bec5..807d21b6c8 100644
--- a/.github/workflows/r.yml
+++ b/.github/workflows/r.yml
@@ -305,7 +305,8 @@ jobs:
RWINLIB_LOCAL = file.path(Sys.getenv("GITHUB_WORKSPACE"), "r",
"windows", "libarrow.zip"),
MAKEFLAGS = paste0("-j", parallel::detectCores()),
ARROW_R_DEV = TRUE,
- "_R_CHECK_FORCE_SUGGESTS_" = FALSE
+ "_R_CHECK_FORCE_SUGGESTS_" = FALSE,
+ "_R_CHECK_STOP_ON_INVALID_NUMERIC_VERSION_INPUTS_" = TRUE
)
rcmdcheck::rcmdcheck(".",
build_args = '--no-build-vignettes',
diff --git a/ci/scripts/r_test.sh b/ci/scripts/r_test.sh
index d7df44e2e4..e0c2ce9efe 100755
--- a/ci/scripts/r_test.sh
+++ b/ci/scripts/r_test.sh
@@ -65,6 +65,8 @@ export _R_CHECK_DONTTEST_EXAMPLES_=TRUE
export _R_CHECK_FORCE_SUGGESTS_=FALSE
export _R_CHECK_LIMIT_CORES_=FALSE
export _R_CHECK_TESTS_NLINES_=0
+# This can cause failures on CRAN but needs to be set here so issues an error
not a warning
+export _R_CHECK_STOP_ON_INVALID_NUMERIC_VERSION_INPUTS_=TRUE
# By default, aws-sdk tries to contact a non-existing local ip host
# to retrieve metadata. Disable this so that S3FileSystem tests run faster.
