This is an automated email from the ASF dual-hosted git repository.
apitrou pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/main by this push:
new 323a92f8f5 MINOR: [Go] Correct benchmark units from bits/s to bytes/s
(#37479)
323a92f8f5 is described below
commit 323a92f8f533f6fbe2ec7c069486041f9fbd1120
Author: Edward Visel <[email protected]>
AuthorDate: Thu Aug 31 08:32:41 2023 -0500
MINOR: [Go] Correct benchmark units from bits/s to bytes/s (#37479)
### Rationale for this change
We're trying to clean up the set of units used in Conbench, and the Go
benchmarks stick out as `b/s` (bits per second), but looking at
https://github.com/apache/arrow/blob/602083be4f9630eda3edaf3ac18a660ccce91468/ci/scripts/go_bench_adapt.py#L86
it looks like they're actually in `B/s` (bytes per second).
### What changes are included in this PR?
Just changing the units submitted to Conbench
### Are these changes tested?
No, but the unit will be validated by the Conbench API
### Are there any user-facing changes?
No
Authored-by: Edward Visel <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
---
ci/scripts/go_bench_adapt.py | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/ci/scripts/go_bench_adapt.py b/ci/scripts/go_bench_adapt.py
index 103712f6d8..e4eea5c17a 100644
--- a/ci/scripts/go_bench_adapt.py
+++ b/ci/scripts/go_bench_adapt.py
@@ -95,7 +95,7 @@ class GoAdapter(BenchmarkAdapter):
batch_id=batch_id,
stats={
"data": [data],
- "unit": "b/s",
+ "unit": "B/s",
"times": [time],
"time_unit": "i/s",
"iterations": benchmark["Runs"],
