This is an automated email from the ASF dual-hosted git repository.

kou pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/main by this push:
     new 715cc98de3 GH-37507: [GLib] Don't use implicit include directories 
(#37508)
715cc98de3 is described below

commit 715cc98de3d1dc03090b2693d36a22c796cf94d2
Author: Sutou Kouhei <[email protected]>
AuthorDate: Fri Sep 1 14:30:47 2023 +0900

    GH-37507: [GLib] Don't use implicit include directories (#37508)
    
    ### Rationale for this change
    
    Our source code should not have "#include"s that depend on source/binary 
directories exists in include path.
    
    This also fixes that CUDA's cuda.h isn't included problem.
    
    ### What changes are included in this PR?
    
    Don't use implicit include directories.
    
    ### Are these changes tested?
    
    Yes.
    
    ### Are there any user-facing changes?
    
    No.
    * Closes: #37507
    
    Authored-by: Sutou Kouhei <[email protected]>
    Signed-off-by: Sutou Kouhei <[email protected]>
---
 c_glib/arrow-cuda-glib/meson.build       | 1 +
 c_glib/arrow-dataset-glib/meson.build    | 1 +
 c_glib/arrow-flight-glib/meson.build     | 1 +
 c_glib/arrow-flight-sql-glib/meson.build | 1 +
 c_glib/arrow-glib/meson.build            | 1 +
 c_glib/gandiva-glib/meson.build          | 1 +
 c_glib/parquet-glib/meson.build          | 1 +
 7 files changed, 7 insertions(+)

diff --git a/c_glib/arrow-cuda-glib/meson.build 
b/c_glib/arrow-cuda-glib/meson.build
index fd9e8f0e7b..1718e2fc99 100644
--- a/c_glib/arrow-cuda-glib/meson.build
+++ b/c_glib/arrow-cuda-glib/meson.build
@@ -43,6 +43,7 @@ libarrow_cuda_glib = library('arrow-cuda-glib',
                              sources: sources,
                              install: true,
                              dependencies: dependencies,
+                             implicit_include_directories: false,
                              include_directories: base_include_directories,
                              soversion: so_version,
                              version: library_version)
diff --git a/c_glib/arrow-dataset-glib/meson.build 
b/c_glib/arrow-dataset-glib/meson.build
index afdbbd79a1..4037cf00b7 100644
--- a/c_glib/arrow-dataset-glib/meson.build
+++ b/c_glib/arrow-dataset-glib/meson.build
@@ -70,6 +70,7 @@ libarrow_dataset_glib = library('arrow-dataset-glib',
                                 sources: sources + enums,
                                 install: true,
                                 dependencies: dependencies,
+                                implicit_include_directories: false,
                                 include_directories: base_include_directories,
                                 soversion: so_version,
                                 version: library_version)
diff --git a/c_glib/arrow-flight-glib/meson.build 
b/c_glib/arrow-flight-glib/meson.build
index 3eb3177a52..b869fd226b 100644
--- a/c_glib/arrow-flight-glib/meson.build
+++ b/c_glib/arrow-flight-glib/meson.build
@@ -48,6 +48,7 @@ libarrow_flight_glib = library('arrow-flight-glib',
                                sources: sources,
                                install: true,
                                dependencies: dependencies,
+                               implicit_include_directories: false,
                                include_directories: base_include_directories,
                                soversion: so_version,
                                version: library_version)
diff --git a/c_glib/arrow-flight-sql-glib/meson.build 
b/c_glib/arrow-flight-sql-glib/meson.build
index 21cec3f0d1..f1ea6d67cb 100644
--- a/c_glib/arrow-flight-sql-glib/meson.build
+++ b/c_glib/arrow-flight-sql-glib/meson.build
@@ -45,6 +45,7 @@ libarrow_flight_sql_glib = library('arrow-flight-sql-glib',
                                    sources: sources,
                                    install: true,
                                    dependencies: dependencies,
+                                   implicit_include_directories: false,
                                    include_directories: 
base_include_directories,
                                    soversion: so_version,
                                    version: library_version)
diff --git a/c_glib/arrow-glib/meson.build b/c_glib/arrow-glib/meson.build
index 2b9c3c2472..b26dcc4c08 100644
--- a/c_glib/arrow-glib/meson.build
+++ b/c_glib/arrow-glib/meson.build
@@ -249,6 +249,7 @@ libarrow_glib = library('arrow-glib',
                         sources: sources + enums,
                         install: true,
                         dependencies: dependencies,
+                        implicit_include_directories: false,
                         include_directories: base_include_directories,
                         soversion: so_version,
                         version: library_version)
diff --git a/c_glib/gandiva-glib/meson.build b/c_glib/gandiva-glib/meson.build
index c397bd1f9f..52729f64da 100644
--- a/c_glib/gandiva-glib/meson.build
+++ b/c_glib/gandiva-glib/meson.build
@@ -85,6 +85,7 @@ libgandiva_glib = library('gandiva-glib',
                           sources: sources + enums,
                           install: true,
                           dependencies: dependencies,
+                          implicit_include_directories: false,
                           include_directories: base_include_directories,
                           soversion: so_version,
                           version: library_version)
diff --git a/c_glib/parquet-glib/meson.build b/c_glib/parquet-glib/meson.build
index 15a2d56383..08288484bf 100644
--- a/c_glib/parquet-glib/meson.build
+++ b/c_glib/parquet-glib/meson.build
@@ -55,6 +55,7 @@ libparquet_glib = library('parquet-glib',
                           sources: sources,
                           install: true,
                           dependencies: dependencies,
+                          implicit_include_directories: false,
                           include_directories: base_include_directories,
                           soversion: so_version,
                           version: library_version)

Reply via email to