This is an automated email from the ASF dual-hosted git repository.
apitrou pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/main by this push:
new e883f893ad GH-35641: [CI][C++] Disable precompiled headers (#37502)
e883f893ad is described below
commit e883f893adecf3d03b390aeaf9185cf166fe3f50
Author: Antoine Pitrou <[email protected]>
AuthorDate: Fri Sep 1 10:28:33 2023 +0200
GH-35641: [CI][C++] Disable precompiled headers (#37502)
### Rationale for this change
ccache does not like precompiled headers and does not cache anything in
that case, which pessimizes build times.
### What changes are included in this PR?
Disable precompiled headers, and enable unity builds to make up for it.
### Are these changes tested?
Yes, by construction.
### Are there any user-facing changes?
No.
* Closes: #35641
Authored-by: Antoine Pitrou <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
---
.github/workflows/cpp.yml | 2 ++
.github/workflows/docs_light.yml | 1 +
.github/workflows/go.yml | 2 ++
.github/workflows/integration.yml | 2 ++
.github/workflows/java.yml | 2 ++
.github/workflows/java_jni.yml | 2 ++
.github/workflows/python.yml | 2 ++
.github/workflows/r.yml | 2 ++
.github/workflows/ruby.yml | 2 ++
.github/workflows/swift.yml | 2 ++
docker-compose.yml | 2 --
11 files changed, 19 insertions(+), 2 deletions(-)
diff --git a/.github/workflows/cpp.yml b/.github/workflows/cpp.yml
index 7dd825c72f..bf110c87b5 100644
--- a/.github/workflows/cpp.yml
+++ b/.github/workflows/cpp.yml
@@ -29,6 +29,7 @@ on:
- 'ci/scripts/msys2_*'
- 'ci/scripts/util_*'
- 'cpp/**'
+ - 'docker-compose.yml'
- 'format/Flight.proto'
pull_request:
paths:
@@ -41,6 +42,7 @@ on:
- 'ci/scripts/msys2_*'
- 'ci/scripts/util_*'
- 'cpp/**'
+ - 'docker-compose.yml'
- 'format/Flight.proto'
concurrency:
diff --git a/.github/workflows/docs_light.yml b/.github/workflows/docs_light.yml
index b1e6a21ead..21185b746e 100644
--- a/.github/workflows/docs_light.yml
+++ b/.github/workflows/docs_light.yml
@@ -27,6 +27,7 @@ on:
- 'ci/docker/conda-python.dockerfile'
- 'ci/scripts/cpp_build.sh'
- 'ci/scripts/python_build.sh'
+ - 'docker-compose.yml'
permissions:
contents: read
diff --git a/.github/workflows/go.yml b/.github/workflows/go.yml
index 4aa3eef785..df4f1207ee 100644
--- a/.github/workflows/go.yml
+++ b/.github/workflows/go.yml
@@ -23,6 +23,7 @@ on:
- '.github/workflows/go.yml'
- 'ci/docker/*_go.dockerfile'
- 'ci/scripts/go_*'
+ - 'docker-compose.yml'
- 'go/**'
pull_request:
paths:
@@ -30,6 +31,7 @@ on:
- 'ci/docker/*_go.dockerfile'
- 'ci/docker/**'
- 'ci/scripts/go_*'
+ - 'docker-compose.yml'
- 'go/**'
concurrency:
diff --git a/.github/workflows/integration.yml
b/.github/workflows/integration.yml
index e7efd11c87..62b61c29bc 100644
--- a/.github/workflows/integration.yml
+++ b/.github/workflows/integration.yml
@@ -23,6 +23,7 @@ on:
- '.github/workflows/integration.yml'
- 'ci/**'
- 'dev/archery/**'
+ - 'docker-compose.yml'
- 'go/**'
- 'integration/**'
- 'js/**'
@@ -34,6 +35,7 @@ on:
- '.github/workflows/integration.yml'
- 'ci/**'
- 'dev/archery/**'
+ - 'docker-compose.yml'
- 'go/**'
- 'integration/**'
- 'js/**'
diff --git a/.github/workflows/java.yml b/.github/workflows/java.yml
index 8a66d7858a..49e500b420 100644
--- a/.github/workflows/java.yml
+++ b/.github/workflows/java.yml
@@ -24,6 +24,7 @@ on:
- 'ci/docker/*java*'
- 'ci/scripts/java*.sh'
- 'ci/scripts/util_*.sh'
+ - 'docker-compose.yml'
- 'format/Flight.proto'
- 'java/**'
pull_request:
@@ -32,6 +33,7 @@ on:
- 'ci/docker/*java*'
- 'ci/scripts/java*.sh'
- 'ci/scripts/util_*.sh'
+ - 'docker-compose.yml'
- 'format/Flight.proto'
- 'java/**'
diff --git a/.github/workflows/java_jni.yml b/.github/workflows/java_jni.yml
index 2787ac1fc7..2bfc7c82c2 100644
--- a/.github/workflows/java_jni.yml
+++ b/.github/workflows/java_jni.yml
@@ -25,6 +25,7 @@ on:
- 'ci/scripts/cpp_build.sh'
- 'ci/scripts/java_*'
- 'cpp/**'
+ - 'docker-compose.yml'
- 'java/**'
pull_request:
paths:
@@ -33,6 +34,7 @@ on:
- 'ci/scripts/cpp_build.sh'
- 'ci/scripts/java_*'
- 'cpp/**'
+ - 'docker-compose.yml'
- 'java/**'
concurrency:
diff --git a/.github/workflows/python.yml b/.github/workflows/python.yml
index bf7d2827f6..76f76411b6 100644
--- a/.github/workflows/python.yml
+++ b/.github/workflows/python.yml
@@ -23,12 +23,14 @@ on:
- '.github/workflows/python.yml'
- 'ci/**'
- 'cpp/**'
+ - 'docker-compose.yml'
- 'python/**'
pull_request:
paths:
- '.github/workflows/python.yml'
- 'ci/**'
- 'cpp/**'
+ - 'docker-compose.yml'
- 'python/**'
concurrency:
diff --git a/.github/workflows/r.yml b/.github/workflows/r.yml
index 807d21b6c8..3e3a4f856e 100644
--- a/.github/workflows/r.yml
+++ b/.github/workflows/r.yml
@@ -27,6 +27,7 @@ on:
- "ci/etc/rprofile"
- "ci/docker/**"
- "cpp/**"
+ - 'docker-compose.yml'
- "r/**"
pull_request:
paths:
@@ -37,6 +38,7 @@ on:
- "ci/etc/rprofile"
- "ci/docker/**"
- "cpp/**"
+ - 'docker-compose.yml'
- "r/**"
concurrency:
diff --git a/.github/workflows/ruby.yml b/.github/workflows/ruby.yml
index af4f34fee2..33f0c5b89c 100644
--- a/.github/workflows/ruby.yml
+++ b/.github/workflows/ruby.yml
@@ -29,6 +29,7 @@ on:
- 'ci/scripts/util_*'
- 'c_glib/**'
- 'cpp/**'
+ - 'docker-compose.yml'
- 'ruby/**'
pull_request:
paths:
@@ -41,6 +42,7 @@ on:
- 'ci/scripts/util_*'
- 'c_glib/**'
- 'cpp/**'
+ - 'docker-compose.yml'
- 'ruby/**'
concurrency:
diff --git a/.github/workflows/swift.yml b/.github/workflows/swift.yml
index 2169dfe525..b2ee3f0b3c 100644
--- a/.github/workflows/swift.yml
+++ b/.github/workflows/swift.yml
@@ -23,12 +23,14 @@ on:
- '.github/workflows/swift.yml'
- 'ci/docker/*swift*'
- 'ci/scripts/swift_*'
+ - 'docker-compose.yml'
- 'swift/**'
pull_request:
paths:
- '.github/workflows/swift.yml'
- 'ci/docker/*swift*'
- 'ci/scripts/swift_*'
+ - 'docker-compose.yml'
- 'swift/**'
concurrency:
diff --git a/docker-compose.yml b/docker-compose.yml
index 8947eadd70..a79b13c0a5 100644
--- a/docker-compose.yml
+++ b/docker-compose.yml
@@ -289,7 +289,6 @@ services:
ARROW_EXTRA_ERROR_CONTEXT: "ON"
ARROW_MIMALLOC: "ON"
ARROW_USE_LD_GOLD: "ON"
- ARROW_USE_PRECOMPILED_HEADERS: "ON"
BUILD_DOCS_PYTHON: "ON"
volumes: &conda-volumes
- .:/arrow:delegated
@@ -1851,7 +1850,6 @@ services:
ARROW_HDFS_TEST_PORT: 8020
ARROW_HDFS_TEST_USER: hdfs
ARROW_S3: "OFF"
- CMAKE_UNITY_BUILD: "ON"
shm_size: *shm-size
volumes: &conda-maven-volumes
- .:/arrow:delegated
