[arrow-adbc] branch main updated: fix(c/driver_manager): Include cerrno in driver manager (#1137)

[lidavidm]

This is an automated email from the ASF dual-hosted git repository.

lidavidm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-adbc.git


The following commit(s) were added to refs/heads/main by this push:
     new 43356cd6 fix(c/driver_manager): Include cerrno in driver manager 
(#1137)
43356cd6 is described below

commit 43356cd6968b396b303a9ff0ff36bc730ceb74ce
Author: Dewey Dunnington <de...@voltrondata.com>
AuthorDate: Fri Sep 29 17:01:52 2023 -0300

    fix(c/driver_manager): Include cerrno in driver manager (#1137)
    
    From CRAN on x86_64-apple-darwin17.0 (64-bit)
    
    ```
    * installing *source* package ‘adbcdrivermanager’ ...
    ** package ‘adbcdrivermanager’ successfully unpacked and MD5 sums checked
    ** using staged installation
    Found vendored ADBC
    ** libs
    clang++ -mmacosx-version-min=10.13 -std=gnu++14 
-I"/Library/Frameworks/R.framework/Resources/include" -DNDEBUG -I../src 
-DADBC_EXPORT=""  -I/usr/local/include   -fPIC  -Wall -g -O2  -c 
adbc_driver_manager.cc -o adbc_driver_manager.o
    adbc_driver_manager.cc:271:83: error: use of undeclared identifier 'EINVAL'
      if (stream->release != ErrorArrayStreamRelease || !stream->private_data) 
return EINVAL;
                                                                                
      ^
    adbc_driver_manager.cc:278:83: error: use of undeclared identifier 'EINVAL'
      if (stream->release != ErrorArrayStreamRelease || !stream->private_data) 
return EINVAL;
                                                                                
      ^
    2 errors generated.
    make: *** [adbc_driver_manager.o] Error 1
    ERROR: compilation failed for package ‘adbcdrivermanager’
    * removing 
‘/Volumes/Builds/packages/high-sierra-x86_64/results/4.2/adbcdrivermanager.Rcheck/adbcdrivermanager’
    ```
    
    I imagine this didn't get caught on CI because their x86 runner for
    "oldrel" is MacOS 10.13 which we don't check (a good thing...it's very
    outdated).
---
 c/driver_manager/adbc_driver_manager.cc  | 1 +
 go/adbc/drivermgr/adbc_driver_manager.cc | 1 +
 2 files changed, 2 insertions(+)

diff --git a/c/driver_manager/adbc_driver_manager.cc 
b/c/driver_manager/adbc_driver_manager.cc
index c28bea93..475af6ee 100644
--- a/c/driver_manager/adbc_driver_manager.cc
+++ b/c/driver_manager/adbc_driver_manager.cc
@@ -21,6 +21,7 @@
 #include <algorithm>
 #include <array>
 #include <cctype>
+#include <cerrno>
 #include <cstring>
 #include <string>
 #include <unordered_map>
diff --git a/go/adbc/drivermgr/adbc_driver_manager.cc 
b/go/adbc/drivermgr/adbc_driver_manager.cc
index c28bea93..475af6ee 100644
--- a/go/adbc/drivermgr/adbc_driver_manager.cc
+++ b/go/adbc/drivermgr/adbc_driver_manager.cc
@@ -21,6 +21,7 @@
 #include <algorithm>
 #include <array>
 #include <cctype>
+#include <cerrno>
 #include <cstring>
 #include <string>
 #include <unordered_map>