This is an automated email from the ASF dual-hosted git repository.

alamb pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-datafusion.git


The following commit(s) were added to refs/heads/main by this push:
     new 3fe07c4c7f Improve update error (#7777)
3fe07c4c7f is described below

commit 3fe07c4c7f56b6b5286cea63b64240114bd955fe
Author: 张林伟 <[email protected]>
AuthorDate: Fri Oct 13 17:57:05 2023 +0800

    Improve update error (#7777)
    
    * Improve update error
    
    * Update datafusion/expr/src/logical_plan/dml.rs
    
    Co-authored-by: Alex Huang <[email protected]>
    
    * Update datafusion/core/src/physical_planner.rs
    
    Co-authored-by: Alex Huang <[email protected]>
    
    * Update datafusion/core/src/physical_planner.rs
    
    Co-authored-by: Alex Huang <[email protected]>
    
    ---------
    
    Co-authored-by: Alex Huang <[email protected]>
---
 datafusion/core/src/physical_planner.rs  | 4 ++--
 datafusion/expr/src/logical_plan/plan.rs | 2 +-
 2 files changed, 3 insertions(+), 3 deletions(-)

diff --git a/datafusion/core/src/physical_planner.rs 
b/datafusion/core/src/physical_planner.rs
index 325927bb73..4055f9f4eb 100644
--- a/datafusion/core/src/physical_planner.rs
+++ b/datafusion/core/src/physical_planner.rs
@@ -1249,10 +1249,10 @@ impl DefaultPhysicalPlanner {
                         "Unsupported logical plan: Prepare"
                     )
                 }
-                LogicalPlan::Dml(_) => {
+                LogicalPlan::Dml(dml) => {
                     // DataFusion is a read-only query engine, but also a 
library, so consumers may implement this
                     not_impl_err!(
-                        "Unsupported logical plan: Dml"
+                        "Unsupported logical plan: Dml({0})", dml.op
                     )
                 }
                 LogicalPlan::Statement(statement) => {
diff --git a/datafusion/expr/src/logical_plan/plan.rs 
b/datafusion/expr/src/logical_plan/plan.rs
index dfc83f9eec..b865b68557 100644
--- a/datafusion/expr/src/logical_plan/plan.rs
+++ b/datafusion/expr/src/logical_plan/plan.rs
@@ -142,7 +142,7 @@ pub enum LogicalPlan {
     Prepare(Prepare),
     /// Data Manipulaton Language (DML): Insert / Update / Delete
     Dml(DmlStatement),
-    /// Data Definition Language (DDL): CREATE / DROP TABLES / VIEWS / SCHEMAs
+    /// Data Definition Language (DDL): CREATE / DROP TABLES / VIEWS / SCHEMAS
     Ddl(DdlStatement),
     /// `COPY TO` for writing plan results to files
     Copy(CopyTo),

Reply via email to