This is an automated email from the ASF dual-hosted git repository.
apitrou pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/main by this push:
new 02ad5ae6cb GH-38117: [C++][Parquet] Change DictEncoder dtor checking
to warning log (#38118)
02ad5ae6cb is described below
commit 02ad5ae6cb24cf02f76fabc818e94539059078ba
Author: mwish <[email protected]>
AuthorDate: Fri Oct 20 00:43:45 2023 +0800
GH-38117: [C++][Parquet] Change DictEncoder dtor checking to warning log
(#38118)
### Rationale for this change
This is a minor change, just change `DCHECK` to warning log.
### What changes are included in this PR?
change `DCHECK` to warning log.
### Are these changes tested?
no, I don't know how to test this, any idea is welcome.
### Are there any user-facing changes?
no
* Closes: #38117
Authored-by: mwish <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
---
cpp/src/parquet/encoding.cc | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/cpp/src/parquet/encoding.cc b/cpp/src/parquet/encoding.cc
index c136671bd1..5221f2588c 100644
--- a/cpp/src/parquet/encoding.cc
+++ b/cpp/src/parquet/encoding.cc
@@ -442,7 +442,7 @@ class DictEncoderImpl : public EncoderImpl, virtual public
DictEncoder<DType> {
dict_encoded_size_(0),
memo_table_(pool, kInitialHashTableSize) {}
- ~DictEncoderImpl() override { DCHECK(buffered_indices_.empty()); }
+ ~DictEncoderImpl() = default;
int dict_encoded_size() const override { return dict_encoded_size_; }