This is an automated email from the ASF dual-hosted git repository.

lidavidm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/main by this push:
     new cb7996f8d6 GH-38387: [Java] Fix JDK8 compilation issue with 
TestAllTypes (#38388)
cb7996f8d6 is described below

commit cb7996f8d62f7a4e306066f993146893100a8a9a
Author: James Duong <[email protected]>
AuthorDate: Sun Oct 22 08:18:51 2023 -0700

    GH-38387: [Java] Fix JDK8 compilation issue with TestAllTypes (#38388)
    
    ### Rationale for this change
    There is a build error due to use of a JDK9 API
    
    ### What changes are included in this PR?
    Change construction of a list of to use JDK8 functions instead of a JDK9 
function.
    
    ### Are these changes tested?
    Yes.
    
    ### Are there any user-facing changes?
    No.
    
    **This PR contains a "Critical Fix".**
    
    * Closes: #38387
    
    Authored-by: James Duong <[email protected]>
    Signed-off-by: David Li <[email protected]>
---
 .../src/test/java/org/apache/arrow/dataset/TestAllTypes.java       | 7 ++++---
 1 file changed, 4 insertions(+), 3 deletions(-)

diff --git 
a/java/dataset/src/test/java/org/apache/arrow/dataset/TestAllTypes.java 
b/java/dataset/src/test/java/org/apache/arrow/dataset/TestAllTypes.java
index d0163bec36..7be49079e7 100644
--- a/java/dataset/src/test/java/org/apache/arrow/dataset/TestAllTypes.java
+++ b/java/dataset/src/test/java/org/apache/arrow/dataset/TestAllTypes.java
@@ -24,6 +24,7 @@ import java.nio.channels.Channels;
 import java.nio.channels.SeekableByteChannel;
 import java.nio.channels.WritableByteChannel;
 import java.util.ArrayList;
+import java.util.Arrays;
 import java.util.Collections;
 import java.util.List;
 import java.util.Objects;
@@ -97,7 +98,7 @@ public class TestAllTypes extends TestDataset {
         new FieldType(false, new ArrowType.Int(32, true), null, null), null));
     Field structField = new Field("struct",
         new FieldType(true, ArrowType.Struct.INSTANCE, null, null), 
childFields);
-    List<Field> fields = List.of(
+    Field[] fields = new Field[] {
         Field.nullablePrimitive("null", ArrowType.Null.INSTANCE),
         Field.nullablePrimitive("bool", ArrowType.Bool.INSTANCE),
         Field.nullablePrimitive("int8", new ArrowType.Int(8, true)),
@@ -132,8 +133,8 @@ public class TestAllTypes extends TestDataset {
         new Field("fixedsizelist", FieldType.nullable(new 
ArrowType.FixedSizeList(2)),
             Collections.singletonList(Field.nullable("items", new 
ArrowType.Int(32, true)))),
         structField
-    );
-    VectorSchemaRoot root = VectorSchemaRoot.create(new Schema(fields), 
allocator);
+    };
+    VectorSchemaRoot root = VectorSchemaRoot.create(new 
Schema(Arrays.asList(fields)), allocator);
     root.allocateNew();
     root.setRowCount(2);
 

Reply via email to