(arrow) branch main updated: GH-38861: [C++] Add missing "-framework Security" to Libs.private in arrow.pc (#38869)

[assignuser]

This is an automated email from the ASF dual-hosted git repository.

assignuser pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/main by this push:
     new eb5de184a7 GH-38861: [C++] Add missing "-framework Security" to 
Libs.private in arrow.pc (#38869)
eb5de184a7 is described below

commit eb5de184a7e5d02f98526332ace54250417bd232
Author: Sutou Kouhei <k...@clear-code.com>
AuthorDate: Sat Nov 25 13:44:05 2023 +0900

    GH-38861: [C++] Add missing "-framework Security" to Libs.private in 
arrow.pc (#38869)
    
    ### Rationale for this change
    
    It's required only when:
    
    * We use bundled aws-sdk-cpp.
    * We use static library for Apache Arrow C++.
    
    Because bundled aws-sdk-cpp uses Security framework.
    
    ### What changes are included in this PR?
    
    Add `-framework Security` to `Libs.private` only on the condition.
    
    ### Are these changes tested?
    
    Yes.
    
    ### Are there any user-facing changes?
    
    Yes.
    * Closes: #38861
    
    Authored-by: Sutou Kouhei <k...@clear-code.com>
    Signed-off-by: Jacob Wujciak-Jens <ja...@wujciak.de>
---
 cpp/cmake_modules/ThirdpartyToolchain.cmake | 3 +++
 cpp/src/arrow/CMakeLists.txt                | 2 +-
 2 files changed, 4 insertions(+), 1 deletion(-)

diff --git a/cpp/cmake_modules/ThirdpartyToolchain.cmake 
b/cpp/cmake_modules/ThirdpartyToolchain.cmake
index 52632d554a..17ad8f4542 100644
--- a/cpp/cmake_modules/ThirdpartyToolchain.cmake
+++ b/cpp/cmake_modules/ThirdpartyToolchain.cmake
@@ -5063,6 +5063,9 @@ if(ARROW_S3)
         string(APPEND ARROW_PC_REQUIRES_PRIVATE " libcurl")
       endif()
       string(APPEND ARROW_PC_REQUIRES_PRIVATE " openssl")
+      if(APPLE)
+        string(APPEND ARROW_PC_LIBS_PRIVATE " -framework Security")
+      endif()
     endif()
   endif()
 
diff --git a/cpp/src/arrow/CMakeLists.txt b/cpp/src/arrow/CMakeLists.txt
index fde30588a6..b64194aa6e 100644
--- a/cpp/src/arrow/CMakeLists.txt
+++ b/cpp/src/arrow/CMakeLists.txt
@@ -598,7 +598,7 @@ if(ARROW_BUILD_BUNDLED_DEPENDENCIES)
                       IMPORTED_LOCATION)
   install(FILES ${arrow_bundled_dependencies_path} ${INSTALL_IS_OPTIONAL}
           DESTINATION ${CMAKE_INSTALL_LIBDIR})
-  string(APPEND ARROW_PC_LIBS_PRIVATE " -larrow_bundled_dependencies")
+  string(PREPEND ARROW_PC_LIBS_PRIVATE " -larrow_bundled_dependencies")
   list(INSERT ARROW_STATIC_INSTALL_INTERFACE_LIBS 0 
"Arrow::arrow_bundled_dependencies")
 endif()