This is an automated email from the ASF dual-hosted git repository.

kou pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/main by this push:
     new 8a644afc77 GH-39136: [C++] Remove needless system Protobuf dependency 
with -DARROW_HDFS=ON (#39137)
8a644afc77 is described below

commit 8a644afc77ebe6333114e503cab29f9b0969618a
Author: Sutou Kouhei <[email protected]>
AuthorDate: Sat Dec 9 07:01:31 2023 +0900

    GH-39136: [C++] Remove needless system Protobuf dependency with 
-DARROW_HDFS=ON (#39137)
    
    ### Rationale for this change
    
    Our HDFS related codes don't depend on Protobuf because we process HDFS via 
external `libhdfs.so` and it's `dlopen()`-ed.
    
    ### What changes are included in this PR?
    
    Remove a needless CMake configuration.
    
    ### Are these changes tested?
    
    Yes.
    
    ### Are there any user-facing changes?
    
    Yes.
    * Closes: #39136
    
    Authored-by: Sutou Kouhei <[email protected]>
    Signed-off-by: Sutou Kouhei <[email protected]>
---
 cpp/CMakeLists.txt | 3 ---
 1 file changed, 3 deletions(-)

diff --git a/cpp/CMakeLists.txt b/cpp/CMakeLists.txt
index bcb298407b..9f17350b25 100644
--- a/cpp/CMakeLists.txt
+++ b/cpp/CMakeLists.txt
@@ -873,9 +873,6 @@ add_dependencies(arrow_test_dependencies toolchain-tests)
 if(ARROW_STATIC_LINK_LIBS)
   add_dependencies(arrow_dependencies ${ARROW_STATIC_LINK_LIBS})
   if(ARROW_HDFS OR ARROW_ORC)
-    if(Protobuf_SOURCE STREQUAL "SYSTEM")
-      list(APPEND ARROW_STATIC_INSTALL_INTERFACE_LIBS 
${ARROW_PROTOBUF_LIBPROTOBUF})
-    endif()
     if(NOT MSVC_TOOLCHAIN)
       list(APPEND ARROW_STATIC_LINK_LIBS ${CMAKE_DL_LIBS})
       list(APPEND ARROW_STATIC_INSTALL_INTERFACE_LIBS ${CMAKE_DL_LIBS})

Reply via email to