This is an automated email from the ASF dual-hosted git repository.
tustvold pushed a commit to branch master
in repository https://gitbox.apache.org/repos/asf/arrow-rs.git
The following commit(s) were added to refs/heads/master by this push:
new a9d219bb49 Remove deprecated try_with_option methods (#5237)
a9d219bb49 is described below
commit a9d219bb49c240ed59dcd57a2b287530fc4e473f
Author: Raphael Taylor-Davies <[email protected]>
AuthorDate: Sat Dec 23 17:03:40 2023 +0000
Remove deprecated try_with_option methods (#5237)
---
object_store/src/aws/builder.rs | 23 -----------------------
object_store/src/azure/builder.rs | 19 -------------------
object_store/src/gcp/builder.rs | 19 -------------------
3 files changed, 61 deletions(-)
diff --git a/object_store/src/aws/builder.rs b/object_store/src/aws/builder.rs
index cf9490d96e..596ff99b0e 100644
--- a/object_store/src/aws/builder.rs
+++ b/object_store/src/aws/builder.rs
@@ -477,29 +477,6 @@ impl AmazonS3Builder {
self
}
- /// Set an option on the builder via a key - value pair.
- ///
- /// This method will return an `UnknownConfigKey` error if key cannot be
parsed into [`AmazonS3ConfigKey`].
- #[deprecated(note = "Use with_config")]
- pub fn try_with_option(self, key: impl AsRef<str>, value: impl
Into<String>) -> Result<Self> {
- Ok(self.with_config(key.as_ref().parse()?, value))
- }
-
- /// Hydrate builder from key value pairs
- ///
- /// This method will return an `UnknownConfigKey` error if any key cannot
be parsed into [`AmazonS3ConfigKey`].
- #[deprecated(note = "Use with_config")]
- #[allow(deprecated)]
- pub fn try_with_options<I: IntoIterator<Item = (impl AsRef<str>, impl
Into<String>)>>(
- mut self,
- options: I,
- ) -> Result<Self> {
- for (key, value) in options {
- self = self.try_with_option(key, value)?;
- }
- Ok(self)
- }
-
/// Get config value via a [`AmazonS3ConfigKey`].
///
/// # Example
diff --git a/object_store/src/azure/builder.rs
b/object_store/src/azure/builder.rs
index 6bd2b265b5..2de0a7c05f 100644
--- a/object_store/src/azure/builder.rs
+++ b/object_store/src/azure/builder.rs
@@ -521,25 +521,6 @@ impl MicrosoftAzureBuilder {
self
}
- /// Set an option on the builder via a key - value pair.
- #[deprecated(note = "Use with_config")]
- pub fn try_with_option(self, key: impl AsRef<str>, value: impl
Into<String>) -> Result<Self> {
- Ok(self.with_config(key.as_ref().parse()?, value))
- }
-
- /// Hydrate builder from key value pairs
- #[deprecated(note = "Use with_config")]
- #[allow(deprecated)]
- pub fn try_with_options<I: IntoIterator<Item = (impl AsRef<str>, impl
Into<String>)>>(
- mut self,
- options: I,
- ) -> Result<Self> {
- for (key, value) in options {
- self = self.try_with_option(key, value)?;
- }
- Ok(self)
- }
-
/// Get config value via a [`AzureConfigKey`].
///
/// # Example
diff --git a/object_store/src/gcp/builder.rs b/object_store/src/gcp/builder.rs
index 21b767ddbb..14c4257dc6 100644
--- a/object_store/src/gcp/builder.rs
+++ b/object_store/src/gcp/builder.rs
@@ -287,25 +287,6 @@ impl GoogleCloudStorageBuilder {
self
}
- /// Set an option on the builder via a key - value pair.
- #[deprecated(note = "Use with_config")]
- pub fn try_with_option(self, key: impl AsRef<str>, value: impl
Into<String>) -> Result<Self> {
- Ok(self.with_config(key.as_ref().parse()?, value))
- }
-
- /// Hydrate builder from key value pairs
- #[deprecated(note = "Use with_config")]
- #[allow(deprecated)]
- pub fn try_with_options<I: IntoIterator<Item = (impl AsRef<str>, impl
Into<String>)>>(
- mut self,
- options: I,
- ) -> Result<Self> {
- for (key, value) in options {
- self = self.try_with_option(key, value)?;
- }
- Ok(self)
- }
-
/// Get config value via a [`GoogleConfigKey`].
///
/// # Example
