This is an automated email from the ASF dual-hosted git repository.

felipecrv pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/main by this push:
     new 7b0c6f9556 GH-39384: [C++] Disable -Werror=attributes for Azure SDK's 
identity.hpp (#39448)
7b0c6f9556 is described below

commit 7b0c6f955675c9ad309afc5f82da1623f9b13a59
Author: Felipe Oliveira Carvalho <[email protected]>
AuthorDate: Thu Jan 4 21:04:25 2024 -0300

    GH-39384: [C++] Disable -Werror=attributes for Azure SDK's identity.hpp 
(#39448)
    
    ### Rationale for this change
    
    Warnings in included headers are causing -Werror builds to fail.
    
    ### What changes are included in this PR?
    
    Push and pop of ignore warning pragmas.
    
    ### Are these changes tested?
    
    I'm asking @ anjakefala to test the build on this branch.
    * Closes: #39384
    
    Authored-by: Felipe Oliveira Carvalho <[email protected]>
    Signed-off-by: Felipe Oliveira Carvalho <[email protected]>
---
 cpp/src/arrow/filesystem/azurefs.cc | 9 +++++++++
 1 file changed, 9 insertions(+)

diff --git a/cpp/src/arrow/filesystem/azurefs.cc 
b/cpp/src/arrow/filesystem/azurefs.cc
index 21350a4904..029e19bc0e 100644
--- a/cpp/src/arrow/filesystem/azurefs.cc
+++ b/cpp/src/arrow/filesystem/azurefs.cc
@@ -18,7 +18,16 @@
 #include "arrow/filesystem/azurefs.h"
 #include "arrow/filesystem/azurefs_internal.h"
 
+// idenfity.hpp triggers -Wattributes warnings cause -Werror builds to fail,
+// so disable it for this file with pragmas.
+#if defined(__GNUC__)
+#pragma GCC diagnostic push
+#pragma GCC diagnostic ignored "-Wattributes"
+#endif
 #include <azure/identity.hpp>
+#if defined(__GNUC__)
+#pragma GCC diagnostic pop
+#endif
 #include <azure/storage/blobs.hpp>
 #include <azure/storage/files/datalake.hpp>
 

Reply via email to