(arrow) branch main updated: MINOR: [C++][Parquet] Remove undefined GetArrowType from schema_internal.h (#39931)

[kou]

This is an automated email from the ASF dual-hosted git repository.

kou pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git


The following commit(s) were added to refs/heads/main by this push:
     new 585e0a252f MINOR: [C++][Parquet] Remove undefined GetArrowType from 
schema_internal.h (#39931)
585e0a252f is described below

commit 585e0a252f327e7136695f586b187b2ba5a3a1e3
Author: Gang Wu <ust...@gmail.com>
AuthorDate: Mon Feb 5 05:55:54 2024 +0800

    MINOR: [C++][Parquet] Remove undefined GetArrowType from schema_internal.h 
(#39931)
    
    ### Rationale for this change
    
    We have redundant declarations below and the 1st one should be removed:
    ```cpp
    Result<std::shared_ptr<::arrow::DataType>> GetArrowType(Type::type 
physical_type,
                                                            const LogicalType& 
logical_type,
                                                            int type_length);
    
    Result<std::shared_ptr<::arrow::DataType>> GetArrowType(
        Type::type physical_type, const LogicalType& logical_type, int 
type_length,
        ::arrow::TimeUnit::type int96_arrow_time_unit = 
::arrow::TimeUnit::NANO);
    ```
    
    ### What changes are included in this PR?
    
    Remove the redundant function declaration described above.
    
    ### Are these changes tested?
    
    Make sure build and test pass.
    
    ### Are there any user-facing changes?
    
    No.
    
    Authored-by: Gang Wu <ust...@gmail.com>
    Signed-off-by: Sutou Kouhei <k...@clear-code.com>
---
 cpp/src/parquet/arrow/schema_internal.h | 4 ----
 1 file changed, 4 deletions(-)

diff --git a/cpp/src/parquet/arrow/schema_internal.h 
b/cpp/src/parquet/arrow/schema_internal.h
index 55292ac35a..f56ba0958a 100644
--- a/cpp/src/parquet/arrow/schema_internal.h
+++ b/cpp/src/parquet/arrow/schema_internal.h
@@ -34,10 +34,6 @@ Result<std::shared_ptr<::arrow::DataType>> FromFLBA(const 
LogicalType& logical_t
 Result<std::shared_ptr<::arrow::DataType>> FromInt32(const LogicalType& 
logical_type);
 Result<std::shared_ptr<::arrow::DataType>> FromInt64(const LogicalType& 
logical_type);
 
-Result<std::shared_ptr<::arrow::DataType>> GetArrowType(Type::type 
physical_type,
-                                                        const LogicalType& 
logical_type,
-                                                        int type_length);
-
 Result<std::shared_ptr<::arrow::DataType>> GetArrowType(
     Type::type physical_type, const LogicalType& logical_type, int type_length,
     ::arrow::TimeUnit::type int96_arrow_time_unit = ::arrow::TimeUnit::NANO);