This is an automated email from the ASF dual-hosted git repository.
agrove pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-datafusion.git
The following commit(s) were added to refs/heads/main by this push:
new ed75d9d95a refactor: fix typo in PruningPredicate::always_true()
(#9283)
ed75d9d95a is described below
commit ed75d9d95aaa4aef6718e4c26dc0751c850ef987
Author: SteveLauC <[email protected]>
AuthorDate: Wed Feb 21 08:58:21 2024 +0800
refactor: fix typo in PruningPredicate::always_true() (#9283)
---
datafusion/core/src/datasource/physical_plan/parquet/mod.rs | 2 +-
datafusion/core/src/datasource/physical_plan/parquet/page_filter.rs | 2 +-
datafusion/core/src/physical_optimizer/pruning.rs | 2 +-
3 files changed, 3 insertions(+), 3 deletions(-)
diff --git a/datafusion/core/src/datasource/physical_plan/parquet/mod.rs
b/datafusion/core/src/datasource/physical_plan/parquet/mod.rs
index 171f7cdc59..badd870848 100644
--- a/datafusion/core/src/datasource/physical_plan/parquet/mod.rs
+++ b/datafusion/core/src/datasource/physical_plan/parquet/mod.rs
@@ -132,7 +132,7 @@ impl ParquetExec {
}
}
})
- .filter(|p| !p.allways_true());
+ .filter(|p| !p.always_true());
let page_pruning_predicate =
predicate.as_ref().and_then(|predicate_expr| {
match PagePruningPredicate::try_new(predicate_expr,
file_schema.clone()) {
diff --git
a/datafusion/core/src/datasource/physical_plan/parquet/page_filter.rs
b/datafusion/core/src/datasource/physical_plan/parquet/page_filter.rs
index f0a8e66089..556ae35d48 100644
--- a/datafusion/core/src/datasource/physical_plan/parquet/page_filter.rs
+++ b/datafusion/core/src/datasource/physical_plan/parquet/page_filter.rs
@@ -116,7 +116,7 @@ impl PagePruningPredicate {
.filter_map(|predicate| {
match PruningPredicate::try_new(predicate.clone(),
schema.clone()) {
Ok(p)
- if (!p.allways_true())
+ if (!p.always_true())
&& (p.required_columns().n_columns() < 2) =>
{
Some(Ok(p))
diff --git a/datafusion/core/src/physical_optimizer/pruning.rs
b/datafusion/core/src/physical_optimizer/pruning.rs
index 648b1f70c5..37f705d8a8 100644
--- a/datafusion/core/src/physical_optimizer/pruning.rs
+++ b/datafusion/core/src/physical_optimizer/pruning.rs
@@ -517,7 +517,7 @@ impl PruningPredicate {
///
/// This happens if the predicate is a literal `true` and
/// literal_guarantees is empty.
- pub fn allways_true(&self) -> bool {
+ pub fn always_true(&self) -> bool {
is_always_true(&self.predicate_expr) &&
self.literal_guarantees.is_empty()
}