This is an automated email from the ASF dual-hosted git repository.
apitrou pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow.git
The following commit(s) were added to refs/heads/main by this push:
new b51c318122 MINOR: [Dev] Remove auto close link forced in PR
description (#40178)
b51c318122 is described below
commit b51c318122ff5db1c6c4c70a69b0c804f9e31704
Author: Antoine Pitrou <[email protected]>
AuthorDate: Wed Feb 21 11:24:06 2024 +0100
MINOR: [Dev] Remove auto close link forced in PR description (#40178)
For some reason, https://github.com/apache/arrow/pull/14783 changed the
automatic GH issue link to a "Closes" reference that will forcefully close the
linked issue *even if the committer chooses not to close the issue using the
merge script*.
Since the original change was done without discussion, this is a MINOR PR
as well.
Authored-by: Antoine Pitrou <[email protected]>
Signed-off-by: Antoine Pitrou <[email protected]>
---
.github/workflows/dev_pr/link.js | 2 +-
1 file changed, 1 insertion(+), 1 deletion(-)
diff --git a/.github/workflows/dev_pr/link.js b/.github/workflows/dev_pr/link.js
index 174bd3bae6..a70dbc604c 100644
--- a/.github/workflows/dev_pr/link.js
+++ b/.github/workflows/dev_pr/link.js
@@ -82,7 +82,7 @@ async function commentJIRAURL(github, context,
pullRequestNumber, jiraID) {
async function commentGitHubURL(github, context, pullRequestNumber, issueID) {
// Make the call to ensure issue exists before adding comment
const issueInfo = await helpers.getGitHubInfo(github, context, issueID,
pullRequestNumber);
- const message = "* Closes: #" + issueInfo.number
+ const message = "* GitHub Issue: #" + issueInfo.number
if (issueInfo) {
const body = context.payload.pull_request.body || "";
if (body.includes(message)) {
