This is an automated email from the ASF dual-hosted git repository.

thisisnic pushed a commit to branch maint-15.0.0-r
in repository https://gitbox.apache.org/repos/asf/arrow.git

commit e11463ee41a72e91b76468779e08058b39f74e8b
Author: Jonathan Keane <[email protected]>
AuthorDate: Thu Feb 1 08:16:56 2024 -0600

    GH-39859: [R] Remove macOS from the allow list (#39861)
    
    Originally this was going to also bundle all of our dependencies to send to 
CRAN, but their webforms don't allow source tars that large (I tried down to 
80MB which removed a large number of our dependencies, and that was still 
rejected by the macbuilder).
    
    This means that on CRAN, if there is no internet, the macOS binary will be 
minimal. But it means that we build on CRAN using source always.
    
    We should definitely submit this to macbuilder after this merges to main 
and confirm we get source build by default (since we look to the repo for our 
allowlist)
    * Closes: #39859
    
    Authored-by: Jonathan Keane <[email protected]>
    Signed-off-by: Jonathan Keane <[email protected]>
---
 r/tools/nixlibs-allowlist.txt | 1 -
 r/tools/nixlibs.R             | 2 +-
 2 files changed, 1 insertion(+), 2 deletions(-)

diff --git a/r/tools/nixlibs-allowlist.txt b/r/tools/nixlibs-allowlist.txt
index 9c368e6ed1..bd9f0c1b2c 100644
--- a/r/tools/nixlibs-allowlist.txt
+++ b/r/tools/nixlibs-allowlist.txt
@@ -2,4 +2,3 @@ ubuntu
 centos
 redhat
 rhel
-darwin
diff --git a/r/tools/nixlibs.R b/r/tools/nixlibs.R
index 72fe6fb6f9..e1908b434e 100644
--- a/r/tools/nixlibs.R
+++ b/r/tools/nixlibs.R
@@ -222,7 +222,7 @@ check_allowlist <- function(os, allowed = 
"https://raw.githubusercontent.com/apa
     # Try a remote allowlist so that we can add/remove without a release
     suppressWarnings(readLines(allowed)),
     # Fallback to default: allowed only on Ubuntu and CentOS/RHEL
-    error = function(e) c("ubuntu", "centos", "redhat", "rhel", "darwin")
+    error = function(e) c("ubuntu", "centos", "redhat", "rhel")
   )
   # allowlist should contain valid regular expressions (plain strings ok too)
   any(grepl(paste(allowlist, collapse = "|"), os))

Reply via email to