This is an automated email from the ASF dual-hosted git repository.

paleolimbot pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-nanoarrow.git


The following commit(s) were added to refs/heads/main by this push:
     new 11e73a8c Increase CMake minimum version, move requirement (#422)
11e73a8c is described below

commit 11e73a8c85b45e3d49c8c541b4e1497a649fe03c
Author: Dirk Eddelbuettel <[email protected]>
AuthorDate: Thu Apr 11 12:35:08 2024 -0500

    Increase CMake minimum version, move requirement (#422)
    
    This is a very minor 'quality of life' improvement to `linesplitter` as
    `cmake` nags about the minimum requirement being after (rather than
    before) the main project declaration, and increasing the version (which
    I understand you may not want to increase by as much) silences the
    TIMESTAMP nag. Feel free to adjust or ignore, I just liked the quieter
    build.
---
 examples/linesplitter/CMakeLists.txt | 8 +++++++-
 1 file changed, 7 insertions(+), 1 deletion(-)

diff --git a/examples/linesplitter/CMakeLists.txt 
b/examples/linesplitter/CMakeLists.txt
index 89f40ba6..29d3a74b 100644
--- a/examples/linesplitter/CMakeLists.txt
+++ b/examples/linesplitter/CMakeLists.txt
@@ -15,11 +15,17 @@
 # specific language governing permissions and limitations
 # under the License.
 
-project(linesplitter)
 cmake_minimum_required(VERSION 3.14)
+project(linesplitter)
 
 set(CMAKE_CXX_STANDARD 11)
 
+# Avoids a warning about timestamps on downloaded files (prefer new policy
+# if available))
+if(${CMAKE_VERSION} VERSION_GREATER_EQUAL "3.23")
+  cmake_policy(SET CMP0135 NEW)
+endif()
+
 include(FetchContent)
 
 fetchcontent_declare(nanoarrow

Reply via email to