alamb commented on code in PR #502: URL: https://github.com/apache/arrow-site/pull/502#discussion_r1576109753
########## datafusion/contributor-guide/architecture.md: ########## @@ -0,0 +1,28 @@ +--- Review Comment: However, I still haven't quite gotten the subdirectories working yet http://localhost:4000/datafusion/user-guide/introduction.html Shows me a "not found" error (as Jekyll has created `datafusion/user-guide/introduction/index.html` (the directory) rather than `datafusion/user-guide/introduction.html` (the file) I ran out of time now, but I will play with this a bit more ########## Gemfile: ########## @@ -27,4 +27,5 @@ group :jekyll_plugins do gem "jekyll-feed", "~> 0.6" gem "jekyll-jupyter-notebook" gem "jekyll-seo-tag" + gem 'jekyll-redirect-from' Review Comment: I am not really familiar with Jekyll and thus I don't know if this is the right approach or not for creating a redirect 🤔 It seems to work but has lots of repeititon Ideally I would like to just make a table with old URLs and redirects but I couldn't figure out how to do that -- This is an automated message from the Apache Git Service. To respond to the message, please log on to GitHub and use the URL above to go to the specific comment. To unsubscribe, e-mail: [email protected] For queries about this service, please contact Infrastructure at: [email protected]
