This is an automated email from the ASF dual-hosted git repository. raulcd pushed a commit to branch maint-16.x.x in repository https://gitbox.apache.org/repos/asf/arrow.git
commit 84e2c8ef1c7892d6f63153cc74ead23d3c2b2908 Author: Austin Dickey <[email protected]> AuthorDate: Wed Apr 10 15:59:05 2024 -0500 GH-41133: [Benchmarking] Build benchmarks in benchmarks.env (#40925) Previously, we were relying on `archery` to build C++ microbenchmarks during Conbench runs. That doubled the build time and ignored all the environment variables set in this file. Along with https://github.com/voltrondata-labs/benchmarks/pull/159, this change will remove the duplicated build. * GitHub Issue: #41133 Authored-by: Austin Dickey <[email protected]> Signed-off-by: Jacob Wujciak-Jens <[email protected]> --- dev/archery/archery/benchmark/google.py | 2 +- dev/conbench_envs/benchmarks.env | 3 +++ dev/conbench_envs/hooks.sh | 3 ++- 3 files changed, 6 insertions(+), 2 deletions(-) diff --git a/dev/archery/archery/benchmark/google.py b/dev/archery/archery/benchmark/google.py index 5d07ffab2e..b07dc8cb30 100644 --- a/dev/archery/archery/benchmark/google.py +++ b/dev/archery/archery/benchmark/google.py @@ -57,7 +57,7 @@ class GoogleBenchmarkCommand(Command): "--benchmark_out_format=json"] if repetition_min_time is not None: - argv.append(f"--benchmark_min_time={repetition_min_time:.6f}") + argv.append(f"--benchmark_min_time={repetition_min_time:.6f}s") if self.benchmark_filter: argv.append(f"--benchmark_filter={self.benchmark_filter}") diff --git a/dev/conbench_envs/benchmarks.env b/dev/conbench_envs/benchmarks.env index 9a4f2da1b5..2a5a9c32a8 100644 --- a/dev/conbench_envs/benchmarks.env +++ b/dev/conbench_envs/benchmarks.env @@ -16,6 +16,8 @@ CMAKE_BUILD_TYPE=release ARROW_BUILD_TESTS=OFF +ARROW_BUILD_BENCHMARKS=ON +ARROW_BUILD_BENCHMARKS_REFERENCE=OFF ARROW_BUILD_TYPE=release ARROW_DEPENDENCY_SOURCE=AUTO ARROW_DATASET=ON @@ -27,6 +29,7 @@ ARROW_GANDIVA=OFF ARROW_HDFS=ON ARROW_HOME=$CONDA_PREFIX ARROW_INSTALL_NAME_RPATH=ON +ARROW_JEMALLOC=OFF ARROW_MIMALLOC=ON ARROW_NO_DEPRECATED_API=ON ARROW_ORC=ON diff --git a/dev/conbench_envs/hooks.sh b/dev/conbench_envs/hooks.sh index 6bcfbe4461..a77189764a 100755 --- a/dev/conbench_envs/hooks.sh +++ b/dev/conbench_envs/hooks.sh @@ -49,8 +49,9 @@ set_arrow_build_and_run_env_vars() { } build_arrow_cpp() { + export ARROW_BUILD_DIR="/tmp/$(uuidgen)" # Ignore the error when a cache can't be created - if ! ci/scripts/cpp_build.sh $(pwd) $(pwd) 2> error.log; then + if ! ci/scripts/cpp_build.sh $(pwd) $ARROW_BUILD_DIR 2> error.log; then if ! grep -q -F "Can\'t create temporary cache file" error.log; then cat error.log fi
