(arrow-adbc) branch main updated: fix(csharp): Change option translation to be case-sensitive (#1820)

[lidavidm]

This is an automated email from the ASF dual-hosted git repository.

lidavidm pushed a commit to branch main
in repository https://gitbox.apache.org/repos/asf/arrow-adbc.git


The following commit(s) were added to refs/heads/main by this push:
     new b2c34e1c6 fix(csharp): Change option translation to be case-sensitive 
(#1820)
b2c34e1c6 is described below

commit b2c34e1c6a9d835de72e5b5595a7a5b5eebd1bd9
Author: Curt Hagenlocher <c...@hagenlocher.org>
AuthorDate: Sun May 5 01:29:40 2024 -0700

    fix(csharp): Change option translation to be case-sensitive (#1820)
    
    Closes #1819
---
 csharp/src/Apache.Arrow.Adbc/AdbcOptions.cs | 37 ++++++++++++++++++-----------
 1 file changed, 23 insertions(+), 14 deletions(-)

diff --git a/csharp/src/Apache.Arrow.Adbc/AdbcOptions.cs 
b/csharp/src/Apache.Arrow.Adbc/AdbcOptions.cs
index b5a54b240..92390f7b6 100644
--- a/csharp/src/Apache.Arrow.Adbc/AdbcOptions.cs
+++ b/csharp/src/Apache.Arrow.Adbc/AdbcOptions.cs
@@ -54,9 +54,12 @@ namespace Apache.Arrow.Adbc
         public static string GetEnabled(bool value) => value ? Enabled : 
Disabled;
         public static bool GetEnabled(string value)
         {
-            if (StringComparer.OrdinalIgnoreCase.Equals(value, Enabled)) { 
return true; }
-            if (StringComparer.OrdinalIgnoreCase.Equals(value, Disabled)) { 
return false; }
-            throw new NotSupportedException("unknown enabled flag");
+            return value switch
+            {
+                Enabled => true,
+                Disabled => false,
+                _ => throw new NotSupportedException("unknown enabled flag"),
+            };
         }
 
         public static string GetIsolationLevel(IsolationLevel value)
@@ -76,14 +79,17 @@ namespace Apache.Arrow.Adbc
 
         public static IsolationLevel GetIsolationLevel(string value)
         {
-            if (StringComparer.OrdinalIgnoreCase.Equals(value, 
IsolationLevels.Default)) { return Adbc.IsolationLevel.Default; }
-            if (StringComparer.OrdinalIgnoreCase.Equals(value, 
IsolationLevels.ReadUncommitted)) { return Adbc.IsolationLevel.ReadUncommitted; 
}
-            if (StringComparer.OrdinalIgnoreCase.Equals(value, 
IsolationLevels.ReadCommitted)) { return Adbc.IsolationLevel.ReadCommitted; }
-            if (StringComparer.OrdinalIgnoreCase.Equals(value, 
IsolationLevels.RepeatableRead)) { return Adbc.IsolationLevel.RepeatableRead; }
-            if (StringComparer.OrdinalIgnoreCase.Equals(value, 
IsolationLevels.Snapshot)) { return Adbc.IsolationLevel.Snapshot; }
-            if (StringComparer.OrdinalIgnoreCase.Equals(value, 
IsolationLevels.Serializable)) { return Adbc.IsolationLevel.Serializable; }
-            if (StringComparer.OrdinalIgnoreCase.Equals(value, 
IsolationLevels.Linearizable)) { return Adbc.IsolationLevel.Linearizable; }
-            throw new NotSupportedException("unknown isolation level");
+            return value switch
+            {
+                IsolationLevels.Default => Adbc.IsolationLevel.Default,
+                IsolationLevels.ReadUncommitted => 
Adbc.IsolationLevel.ReadUncommitted,
+                IsolationLevels.ReadCommitted => 
Adbc.IsolationLevel.ReadCommitted,
+                IsolationLevels.RepeatableRead => 
Adbc.IsolationLevel.RepeatableRead,
+                IsolationLevels.Snapshot => Adbc.IsolationLevel.Snapshot,
+                IsolationLevels.Serializable => 
Adbc.IsolationLevel.Serializable,
+                IsolationLevels.Linearizable => 
Adbc.IsolationLevel.Linearizable,
+                _ => throw new NotSupportedException("unknown isolation 
level"),
+            };
         }
 
         public static string GetIngestMode(BulkIngestMode value)
@@ -98,9 +104,12 @@ namespace Apache.Arrow.Adbc
 
         public static BulkIngestMode GetIngestMode(string value)
         {
-            if (StringComparer.OrdinalIgnoreCase.Equals(value, 
IngestMode.Create)) { return BulkIngestMode.Create; }
-            if (StringComparer.OrdinalIgnoreCase.Equals(value, 
IngestMode.Append)) { return BulkIngestMode.Append; }
-            throw new NotSupportedException("unknown ingestion mode");
+            return value switch
+            {
+                IngestMode.Create => BulkIngestMode.Create,
+                IngestMode.Append => BulkIngestMode.Append,
+                _ => throw new NotSupportedException("unknown ingestion mode"),
+            };
         }
     }
 }